Revert of Some more minor cleanup to ApplicationManager.

Revert of Some more minor cleanup to ApplicationManager. (patchset #4 id:60001 of https://codereview.chromium.org/1351963002/ )

Reason for revert:
Broke Android GN.

Original issue's description:
> Some more minor cleanup to ApplicationManager.
>
> R=yzshen@chromium.org
> http://crbug.com/533085
>
> Committed: https://crrev.com/c6bde172a35b65b5a735675e840fab55921d28f8
> Cr-Commit-Position: refs/heads/master@{#349515}

TBR=yzshen@chromium.org,ben@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Committed: https://crrev.com/4dff1d58fa60695afac0aa3da11634378c0d7aad
Cr-Commit-Position: refs/heads/master@{#349554}

[Justin Donnelly, 2015-09-17 23:44:24]

Created Revert of Some more minor cleanup to ApplicationManager.

[commit-bot: I haz the power, 2015-09-17 23:45:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1354043002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1354043002/1

[commit-bot: I haz the power, 2015-09-17 23:46:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-17 23:46:41]

Failed to apply patch for mojo/shell/application_manager.cc:
While running git apply --index -3 -p1;
  error: patch failed: mojo/shell/application_manager.cc:127
  Falling back to three-way merge...
  Applied patch to 'mojo/shell/application_manager.cc' with conflicts.
  U mojo/shell/application_manager.cc

Patch:       mojo/shell/application_manager.cc
Index: mojo/shell/application_manager.cc
diff --git a/mojo/shell/application_manager.cc
b/mojo/shell/application_manager.cc
index
715e6e77c7499a044ddefd538fefdd940354d6b7..d52030476cf3fddbc84b25274257c547d6d30c3b
100644
--- a/mojo/shell/application_manager.cc
+++ b/mojo/shell/application_manager.cc
@@ -59,9 +59,8 @@
 }
 
 ApplicationManager::~ApplicationManager() {
-  IdentityToContentHandlerMap identity_to_content_handler(
-      identity_to_content_handler_);
-  for (auto& pair : identity_to_content_handler)
+  URLToContentHandlerMap url_to_content_handler(url_to_content_handler_);
+  for (auto& pair : url_to_content_handler)
     pair.second->CloseConnection();
   TerminateShellConnections();
   STLDeleteValues(&url_to_loader_);
@@ -69,6 +68,28 @@
 
 void ApplicationManager::TerminateShellConnections() {
   STLDeleteValues(&identity_to_instance_);
+}
+
+void ApplicationManager::ConnectToApplication(
+    ApplicationInstance* originator,
+    URLRequestPtr app_url_request,
+    const std::string& qualifier,
+    InterfaceRequest<ServiceProvider> services,
+    ServiceProviderPtr exposed_services,
+    const CapabilityFilter& filter,
+    const base::Closure& on_application_end,
+    const Shell::ConnectToApplicationCallback& connect_callback) {
+  scoped_ptr<ConnectToApplicationParams> params(new
ConnectToApplicationParams);
+  params->SetOriginatorInfo(originator);
+  params->SetURLInfo(app_url_request.Pass());
+  params->set_qualifier(qualifier);
+  params->set_services(services.Pass());
+  params->set_exposed_services(exposed_services.Pass());
+  params->set_filter(filter);
+  params->set_on_application_end(on_application_end);
+  params->set_connect_callback(connect_callback);
+
+  ConnectToApplication(params.Pass());
 }
 
 void ApplicationManager::ConnectToApplication(
@@ -127,10 +148,10 @@
   if (!(*params)->app_url().SchemeIs("mojo"))
     (*params)->SetURLInfo(resolved_url);
 
-  loader->Load(resolved_url, CreateInstance(params->Pass(), nullptr));
-}
-
-InterfaceRequest<Application> ApplicationManager::CreateInstance(
+  loader->Load(resolved_url, RegisterInstance(params->Pass(), nullptr));
+}
+
+InterfaceRequest<Application> ApplicationManager::RegisterInstance(
     scoped_ptr<ConnectToApplicationParams> params,
     ApplicationInstance** resulting_instance) {
   Identity app_identity(params->app_url(), params->qualifier());
@@ -204,7 +225,7 @@
       params->connect_callback();
   params->set_connect_callback(EmptyConnectCallback());
   ApplicationInstance* app = nullptr;
-  InterfaceRequest<Application> request(CreateInstance(params.Pass(), &app));
+  InterfaceRequest<Application> request(RegisterInstance(params.Pass(), &app));
 
 
   GURL content_handler_url;
@@ -278,18 +299,17 @@
     InterfaceRequest<Application> application_request,
     URLResponsePtr url_response) {
   ContentHandlerConnection* connection = nullptr;
-  Identity content_handler_identity(content_handler_url, qualifier);
+  std::pair<GURL, std::string> key(content_handler_url, qualifier);
   // TODO(beng): Figure out the extent to which capability filter should be
   //             factored into handler identity.
-  IdentityToContentHandlerMap::iterator iter =
-      identity_to_content_handler_.find(content_handler_identity);
-  if (iter != identity_to_content_handler_.end()) {
+  URLToContentHandlerMap::iterator iter = url_to_content_handler_.find(key);
+  if (iter != url_to_content_handler_.end()) {
     connection = iter->second;
   } else {
     connection = new ContentHandlerConnection(
         this, originator_identity, originator_filter, content_handler_url,
         qualifier, filter, ++content_handler_id_counter_);
-    identity_to_content_handler_[content_handler_identity] = connection;
+    url_to_content_handler_[key] = connection;
   }
 
   app->set_requesting_content_handler_id(connection->id());
@@ -330,11 +350,11 @@
 void ApplicationManager::OnContentHandlerConnectionClosed(
     ContentHandlerConnection* content_handler) {
   // Remove the mapping to the content handler.
-  auto it = identity_to_content_handler_.find(
-      Identity(content_handler->content_handler_url(),
-               content_handler->content_handler_qualifier()));
-  DCHECK(it != identity_to_content_handler_.end());
-  identity_to_content_handler_.erase(it);
+  auto it = url_to_content_handler_.find(
+      std::make_pair(content_handler->content_handler_url(),
+                     content_handler->content_handler_qualifier()));
+  DCHECK(it != url_to_content_handler_.end());
+  url_to_content_handler_.erase(it);
 }
 
 void ApplicationManager::CleanupRunner(NativeRunner* runner) {
@@ -342,6 +362,20 @@
       std::find(native_runners_.begin(), native_runners_.end(), runner));
 }
 
+ScopedMessagePipeHandle ApplicationManager::ConnectToServiceByName(
+    const GURL& application_url,
+    const std::string& interface_name) {
+  ServiceProviderPtr services;
+  scoped_ptr<ConnectToApplicationParams> params(new
ConnectToApplicationParams);
+  params->SetURLInfo(application_url);
+  params->set_services(GetProxy(&services));
+  params->set_filter(GetPermissiveCapabilityFilter());
+  ConnectToApplication(params.Pass());
+  MessagePipe pipe;
+  services->ConnectToService(interface_name, pipe.handle1.Pass());
+  return pipe.handle0.Pass();
+}
+
 Shell::ConnectToApplicationCallback EmptyConnectCallback() {
   return base::Bind(&OnEmptyOnConnectCallback);
 }

[commit-bot: I haz the power, 2015-09-17 23:48:45]

The CQ bit was unchecked by commit-bot@chromium.org

[Justin Donnelly, 2015-09-18 00:46:36]

The CQ bit was checked by jdonnelly@chromium.org

[Justin Donnelly, 2015-09-18 00:47:28]

Reverted follow-on change in https://codereview.chromium.org/1354813002/. Trying
to land this again now.

[commit-bot: I haz the power, 2015-09-18 00:47:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1354043002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1354043002/1

[commit-bot: I haz the power, 2015-09-18 00:49:29]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-09-18 00:50:11]

Patchset 1 (id:??) landed as
https://crrev.com/4dff1d58fa60695afac0aa3da11634378c0d7aad
Cr-Commit-Position: refs/heads/master@{#349554}