Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 13540003: Remove code duplication in JSObject::HasRealNamedProperty (Closed)

Created:
7 years, 8 months ago by adamk
Modified:
7 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Remove code duplication in JSObject::HasRealElementProperty Committed: https://code.google.com/p/v8/source/detail?r=14144

Patch Set 1 #

Total comments: 2

Patch Set 2 : Pass Isolate through #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -66 lines) Patch
M src/api.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M src/objects.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/objects.cc View 1 2 chunks +6 lines, -59 lines 0 comments Download
M src/runtime.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
adamk
7 years, 8 months ago (2013-04-04 00:18:13 UTC) #1
Toon Verwaest
lgtm with comment https://codereview.chromium.org/13540003/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/13540003/diff/1/src/objects.cc#newcode11558 src/objects.cc:11558: Isolate* isolate = GetIsolate(); Since this ...
7 years, 8 months ago (2013-04-04 13:06:17 UTC) #2
adamk
https://codereview.chromium.org/13540003/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/13540003/diff/1/src/objects.cc#newcode11558 src/objects.cc:11558: Isolate* isolate = GetIsolate(); On 2013/04/04 13:06:17, Toon Verwaest ...
7 years, 8 months ago (2013-04-04 19:09:46 UTC) #3
adamk
7 years, 8 months ago (2013-04-04 19:13:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r14144 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698