Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Issue 135393002: Add CF_HDROP path for dragging on Win Aura (Closed)

Created:
6 years, 11 months ago by scottmg
Modified:
6 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Add CF_HDROP path for dragging on Win Aura This ports the PrepareDragForDownload path over from the native windows code path. This makes dragging files to explorer from, for example, gmail save the content of the file, rather than a link, or the thumbnail image. (This needs to be merged to 32, so attempted to keep it semi-localized.) BUG=332579, 333320 R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244355

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : reupload #

Total comments: 2

Patch Set 4 : nl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -2 lines) Patch
M content/browser/web_contents/web_contents_view_aura.cc View 1 2 3 5 chunks +70 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scottmg
6 years, 11 months ago (2014-01-11 04:55:41 UTC) #1
Ben Goodger (Google)
lgtm https://codereview.chromium.org/135393002/diff/60001/content/browser/web_contents/web_contents_view_aura.cc File content/browser/web_contents/web_contents_view_aura.cc (right): https://codereview.chromium.org/135393002/diff/60001/content/browser/web_contents/web_contents_view_aura.cc#newcode299 content/browser/web_contents/web_contents_view_aura.cc:299: base::FilePath download_path = nit: nl above
6 years, 11 months ago (2014-01-11 05:01:46 UTC) #2
scottmg
https://codereview.chromium.org/135393002/diff/60001/content/browser/web_contents/web_contents_view_aura.cc File content/browser/web_contents/web_contents_view_aura.cc (right): https://codereview.chromium.org/135393002/diff/60001/content/browser/web_contents/web_contents_view_aura.cc#newcode299 content/browser/web_contents/web_contents_view_aura.cc:299: base::FilePath download_path = On 2014/01/11 05:01:47, Ben Goodger (Google) ...
6 years, 11 months ago (2014-01-11 05:02:46 UTC) #3
scottmg
6 years, 11 months ago (2014-01-11 17:52:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r244355.

Powered by Google App Engine
This is Rietveld 408576698