Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(96)

Issue 1353873002: Fix inconsistent APIs (Closed)

Created:
4 years ago by vsm
Modified:
4 years ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/collection.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix inconsistent APIs Strong mode is complaining about these - they are not consistent with the corresponding APIs in Map and Set. R=lrn@google.com, nweiz@google.com Committed: https://github.com/dart-lang/collection/commit/5ab8354b59adae6c2ec1ee232274674f1850aa64

Patch Set 1 #

Patch Set 2 : Bump version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M CHANGELOG.md View 1 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/unmodifiable_wrappers.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/wrappers.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
vsm
4 years ago (2015-09-17 15:49:46 UTC) #2
nweiz
Can you bump the patch version and add a CHANGELOG entry?
4 years ago (2015-09-17 19:31:21 UTC) #3
vsm
On 2015/09/17 19:31:21, nweiz wrote: > Can you bump the patch version and add a ...
4 years ago (2015-09-17 19:38:59 UTC) #4
nweiz
LGTM! Don't forget to tag and publish.
4 years ago (2015-09-17 20:03:30 UTC) #5
Lasse Reichstein Nielsen
LGTM too!
4 years ago (2015-09-17 20:26:02 UTC) #6
vsm
Committed patchset #2 (id:20001) manually as 5ab8354b59adae6c2ec1ee232274674f1850aa64 (presubmit successful).
4 years ago (2015-09-17 20:55:47 UTC) #7
vsm
4 years ago (2015-09-17 20:59:07 UTC) #8
Message was sent while issue was closed.
On 2015/09/17 20:55:47, vsm wrote:
> Committed patchset #2 (id:20001) manually as
> 5ab8354b59adae6c2ec1ee232274674f1850aa64 (presubmit successful).

Thanks!  Just tagged and pub-lished as well.

Powered by Google App Engine
This is Rietveld 408576698