Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 1353723002: [runtime] Initial step towards switching Execution::Call to callable. (Closed)

Created:
5 years, 3 months ago by Benedikt Meurer
Modified:
5 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Initial step towards switching Execution::Call to callable. Currently Execution::Call (and friends) still duplicate a lot of the Call sequence logic that should be encapsulated in the Call and CallFunction builtins. So the plan now is to switch Execution::Call to accept any Callable and just pass that through to the Call builtin. CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg R=jarin@chromium.org BUG=v8:4413 LOG=n Committed: https://crrev.com/359645f48156e15f235e9a9ede7910e0bcd9ae45 Cr-Commit-Position: refs/heads/master@{#30791} Committed: https://crrev.com/d5bbd45f044ae6796c0d0f7bd8732069d74418de Cr-Commit-Position: refs/heads/master@{#30808}

Patch Set 1 #

Patch Set 2 : Handle sloppy mode api functions correctly. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -141 lines) Patch
M src/api.cc View 17 chunks +50 lines, -56 lines 0 comments Download
M src/arm/builtins-arm.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/execution.h View 1 chunk +8 lines, -15 lines 0 comments Download
M src/execution.cc View 1 5 chunks +32 lines, -38 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/objects.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-function.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 chunk +1 line, -3 lines 0 comments Download
M test/cctest/compiler/function-tester.h View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 31 (11 generated)
Benedikt Meurer
5 years, 3 months ago (2015-09-17 06:58:53 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1353723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1353723002/1
5 years, 3 months ago (2015-09-17 06:59:13 UTC) #3
Benedikt Meurer
Hey Jaro, Next tiny step towards a single bottleneck for the Call sequence; removing magic ...
5 years, 3 months ago (2015-09-17 06:59:41 UTC) #4
Jarin
lgtm
5 years, 3 months ago (2015-09-17 07:23:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1353723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1353723002/1
5 years, 3 months ago (2015-09-17 07:24:27 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_layout_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_layout_dbg/builds/1649)
5 years, 3 months ago (2015-09-17 09:02:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1353723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1353723002/1
5 years, 3 months ago (2015-09-17 09:03:52 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-17 09:05:33 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/359645f48156e15f235e9a9ede7910e0bcd9ae45 Cr-Commit-Position: refs/heads/master@{#30791}
5 years, 3 months ago (2015-09-17 09:05:57 UTC) #14
Michael Achenbach
Why land with obvious layout test failures? The policy is to fix those beforehand (if ...
5 years, 3 months ago (2015-09-17 10:06:44 UTC) #15
Michael Achenbach
OK - the second test run doesn't show useful results - I admit that. But ...
5 years, 3 months ago (2015-09-17 10:07:50 UTC) #16
Michael Achenbach
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1346763005/ by machenbach@chromium.org. ...
5 years, 3 months ago (2015-09-17 10:11:21 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1353723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1353723002/20001
5 years, 3 months ago (2015-09-17 11:58:12 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_layout_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_layout_dbg/builds/1654)
5 years, 3 months ago (2015-09-17 12:48:48 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1353723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1353723002/20001
5 years, 3 months ago (2015-09-17 17:06:39 UTC) #24
Benedikt Meurer
On 2015/09/17 10:07:50, Michael Achenbach wrote: > OK - the second test run doesn't show ...
5 years, 3 months ago (2015-09-17 17:09:00 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1353723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1353723002/20001
5 years, 3 months ago (2015-09-17 17:09:58 UTC) #28
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-17 17:11:44 UTC) #29
Benedikt Meurer
On 2015/09/17 17:09:00, Benedikt Meurer wrote: > On 2015/09/17 10:07:50, Michael Achenbach wrote: > > ...
5 years, 3 months ago (2015-09-17 17:11:51 UTC) #30
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 17:12:05 UTC) #31
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d5bbd45f044ae6796c0d0f7bd8732069d74418de
Cr-Commit-Position: refs/heads/master@{#30808}

Powered by Google App Engine
This is Rietveld 408576698