Issue 1353703006: Revert of Combined approach.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1353703006: Revert of Combined approach. (Closed)

Created:
5 years, 3 months ago by mtklein

Modified:
5 years, 3 months ago

Reviewers:
mtklein_C, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Combined approach. (patchset #2 id:20001 of https://codereview.chromium.org/1356133002/ ) Reason for revert: whee Original issue's description: > Combined approach. > > This combines some ideas from these two CLs: > - try stosd/w > - update memset16/32 inlining heuristics > > > BUG=skia:4316 > > Blinking in and out for perf.skia.org. > TBR=reed@google.com > > Committed: https://skia.googlesource.com/skia/+/46243a7c02a1d5116e55a27ff59218f9c320df97 TBR=reed@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4316 Committed: https://skia.googlesource.com/skia/+/b758bbd84e6d4556376850186252777a1a239f4a

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -29 lines)			Patch
	M	include/core/SkUtils.h	View		4 chunks	+13 lines, -29 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1353703006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1353703006/1

5 years, 3 months ago (2015-09-21 18:02:34 UTC) #2

commit-bot: I haz the power

5 years, 3 months ago (2015-09-21 18:02:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b758bbd84e6d4556376850186252777a1a239f4a

Expand Messages | Collapse Messages