Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1353673004: Add some unit tests for pylib.utils.proguard (Closed)

Created:
5 years, 3 months ago by mnaganov (inactive)
Modified:
5 years, 3 months ago
Reviewers:
jbudorick
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add some unit tests for pylib.utils.proguard Verify parsing of ProGuard output. BUG=526885 Committed: https://crrev.com/b92e84b60aadede7ef78ceb55f4b55f6fc43b5a1 Cr-Commit-Position: refs/heads/master@{#349483}

Patch Set 1 #

Patch Set 2 : Restored empty line #

Total comments: 3

Patch Set 3 : Split into separate tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -79 lines) Patch
M build/android/pylib/constants/__init__.py View 1 chunk +2 lines, -1 line 0 comments Download
M build/android/pylib/utils/proguard.py View 1 1 chunk +77 lines, -78 lines 0 comments Download
A build/android/pylib/utils/proguard_test.py View 1 2 1 chunk +98 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
mnaganov (inactive)
PTAL! Please note that I have only changed indentation of the parsing code, despite what ...
5 years, 3 months ago (2015-09-17 17:06:32 UTC) #2
jbudorick
This is awesome. https://codereview.chromium.org/1353673004/diff/20001/build/android/pylib/constants/__init__.py File build/android/pylib/constants/__init__.py (left): https://codereview.chromium.org/1353673004/diff/20001/build/android/pylib/constants/__init__.py#oldcode193 build/android/pylib/constants/__init__.py:193: 'devil.utils.md5sum_test', o_o oops https://codereview.chromium.org/1353673004/diff/20001/build/android/pylib/utils/proguard_test.py File build/android/pylib/utils/proguard_test.py ...
5 years, 3 months ago (2015-09-17 17:10:02 UTC) #3
mnaganov (inactive)
https://codereview.chromium.org/1353673004/diff/20001/build/android/pylib/utils/proguard_test.py File build/android/pylib/utils/proguard_test.py (right): https://codereview.chromium.org/1353673004/diff/20001/build/android/pylib/utils/proguard_test.py#newcode14 build/android/pylib/utils/proguard_test.py:14: ['- Program class: org/example/Test', On 2015/09/17 17:10:02, jbudorick wrote: ...
5 years, 3 months ago (2015-09-17 17:19:43 UTC) #4
jbudorick
lgtm
5 years, 3 months ago (2015-09-17 17:20:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1353673004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1353673004/40001
5 years, 3 months ago (2015-09-17 19:14:25 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-17 20:26:19 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 20:26:52 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/b92e84b60aadede7ef78ceb55f4b55f6fc43b5a1
Cr-Commit-Position: refs/heads/master@{#349483}

Powered by Google App Engine
This is Rietveld 408576698