Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Unified Diff: Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 1353653003: DevTools: cleanup timeline concise record details generation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fixed WS urls to be those of WS, not script Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelineUIUtils.js
diff --git a/Source/devtools/front_end/timeline/TimelineUIUtils.js b/Source/devtools/front_end/timeline/TimelineUIUtils.js
index a3690a84eef64efef142e2553e569ad1a7815a60..90e4339d8fd277f15e9938a9eba12a97feca1f15 100644
--- a/Source/devtools/front_end/timeline/TimelineUIUtils.js
+++ b/Source/devtools/front_end/timeline/TimelineUIUtils.js
@@ -291,18 +291,12 @@ WebInspector.TimelineUIUtils.buildDetailsTextForTraceEvent = function(event, tar
var delta = event.args["usedHeapSizeBefore"] - event.args["usedHeapSizeAfter"];
detailsText = WebInspector.UIString("%s collected", Number.bytesToString(delta));
break;
- case recordType.TimerFire:
- detailsText = eventData["timerId"];
- break;
case recordType.FunctionCall:
detailsText = linkifyLocationAsText(eventData["scriptId"], eventData["scriptLine"], 0);
break;
case recordType.JSFrame:
detailsText = WebInspector.beautifyFunctionName(eventData["functionName"]);
break;
- case recordType.FireAnimationFrame:
- detailsText = eventData["id"];
- break;
case recordType.EventDispatch:
detailsText = eventData ? eventData["type"] : null;
break;
@@ -312,56 +306,42 @@ WebInspector.TimelineUIUtils.buildDetailsTextForTraceEvent = function(event, tar
if (width && height)
detailsText = WebInspector.UIString("%d\u2009\u00d7\u2009%d", width, height);
break;
- case recordType.TimerInstall:
- case recordType.TimerRemove:
- detailsText = linkifyTopCallFrameAsText() || eventData["timerId"];
- break;
- case recordType.RequestAnimationFrame:
- case recordType.CancelAnimationFrame:
- detailsText = linkifyTopCallFrameAsText() || eventData["id"];
- break;
case recordType.ParseHTML:
var endLine = event.args["endData"] && event.args["endData"]["endLine"];
- var url = event.args["beginData"]["url"];
+ var url = WebInspector.displayNameForURL(event.args["beginData"]["url"]);
detailsText = endLine ? WebInspector.UIString("%s [%d\u2009\u2013\u2009%d]", url, event.args["beginData"]["startLine"] + 1, endLine + 1) : url;
break;
- case recordType.UpdateLayoutTree:
- case recordType.RecalculateStyles:
- detailsText = linkifyTopCallFrameAsText();
- break;
+
case recordType.EvaluateScript:
var url = eventData["url"];
if (url)
- detailsText = url + ":" + eventData["lineNumber"];
+ detailsText = detailsText = WebInspector.displayNameForURL(url) + ":" + eventData["lineNumber"];
break;
case recordType.XHRReadyStateChange:
case recordType.XHRLoad:
- case recordType.ResourceSendRequest:
var url = eventData["url"];
if (url)
- detailsText = WebInspector.displayNameForURL(url);
+ detailsText = detailsText = WebInspector.displayNameForURL(url);
break;
+
+ case recordType.WebSocketCreate:
+ case recordType.WebSocketSendHandshakeRequest:
+ case recordType.WebSocketReceiveHandshakeResponse:
+ case recordType.WebSocketDestroy:
+ case recordType.ResourceSendRequest:
case recordType.ResourceReceivedData:
case recordType.ResourceReceiveResponse:
case recordType.ResourceFinish:
- var initiator = event.initiator;
- if (initiator) {
- var url = initiator.args["data"]["url"];
- if (url)
- detailsText = WebInspector.displayNameForURL(url);
- }
- break;
- case recordType.EmbedderCallback:
- detailsText = eventData["callbackName"];
- break;
-
case recordType.PaintImage:
case recordType.DecodeImage:
case recordType.ResizeImage:
case recordType.DecodeLazyPixelRef:
- var url = event.url;
- if (url)
- detailsText = WebInspector.displayNameForURL(url);
+ if (event.url)
+ detailsText = WebInspector.displayNameForURL(event.url);
+ break;
+
+ case recordType.EmbedderCallback:
+ detailsText = eventData["callbackName"];
break;
case recordType.Animation:
@@ -392,7 +372,7 @@ WebInspector.TimelineUIUtils.buildDetailsTextForTraceEvent = function(event, tar
if (!rawLocation)
return null;
var uiLocation = WebInspector.debuggerWorkspaceBinding.rawLocationToUILocation(rawLocation);
- return uiLocation.toUIString();
+ return uiLocation.linkText();
}
/**
@@ -429,24 +409,29 @@ WebInspector.TimelineUIUtils.buildDetailsNodeForTraceEvent = function(event, tar
case recordType.GCEvent:
case recordType.MajorGC:
case recordType.MinorGC:
- case recordType.TimerFire:
- case recordType.FireAnimationFrame:
case recordType.EventDispatch:
case recordType.Paint:
+ case recordType.Animation:
+ case recordType.EmbedderCallback:
+ case recordType.ParseHTML:
+ case recordType.WebSocketCreate:
+ case recordType.WebSocketSendHandshakeRequest:
+ case recordType.WebSocketReceiveHandshakeResponse:
+ case recordType.WebSocketDestroy:
+ detailsText = WebInspector.TimelineUIUtils.buildDetailsTextForTraceEvent(event, target);
+ break;
case recordType.PaintImage:
case recordType.DecodeImage:
case recordType.ResizeImage:
case recordType.DecodeLazyPixelRef:
- case recordType.Animation:
case recordType.XHRReadyStateChange:
case recordType.XHRLoad:
case recordType.ResourceSendRequest:
case recordType.ResourceReceivedData:
case recordType.ResourceReceiveResponse:
case recordType.ResourceFinish:
- case recordType.EmbedderCallback:
- case recordType.ParseHTML:
- detailsText = WebInspector.TimelineUIUtils.buildDetailsTextForTraceEvent(event, target);
+ if (event.url)
+ details = WebInspector.linkifyResourceAsNode(event.url);
break;
case recordType.FunctionCall:
details = linkifyLocation(eventData["scriptId"], eventData["scriptName"], eventData["scriptLine"], 0);
@@ -460,20 +445,6 @@ WebInspector.TimelineUIUtils.buildDetailsNodeForTraceEvent = function(event, tar
details.appendChild(location);
}
break;
- case recordType.TimerInstall:
- case recordType.TimerRemove:
- details = linkifyTopCallFrame();
- detailsText = eventData["timerId"];
- break;
- case recordType.RequestAnimationFrame:
- case recordType.CancelAnimationFrame:
- details = linkifyTopCallFrame();
- detailsText = eventData["id"];
- break;
- case recordType.UpdateLayoutTree:
- case recordType.RecalculateStyles:
- details = linkifyTopCallFrame();
- break;
case recordType.EvaluateScript:
var url = eventData["url"];
if (url)

Powered by Google App Engine
This is Rietveld 408576698