| OLD | NEW |
|---|
| (Empty) |
| 1 #!/usr/bin/env python | |
| 2 # Copyright (c) 2011 The Chromium Authors. All rights reserved. | |
| 3 # Use of this source code is governed by a BSD-style license that can be | |
| 4 # found in the LICENSE file. | |
| 5 | |
| 6 """Unit tests for verification/reviewer_lgtm.py.""" | |
| 7 | |
| 8 import logging | |
| 9 import os | |
| 10 import re | |
| 11 import sys | |
| 12 import unittest | |
| 13 | |
| 14 ROOT_DIR = os.path.dirname(os.path.abspath(__file__)) | |
| 15 sys.path.insert(0, os.path.join(ROOT_DIR, '..')) | |
| 16 | |
| 17 from verification import base | |
| 18 from verification import reviewer_lgtm | |
| 19 | |
| 20 # From tests/ | |
| 21 import mocks | |
| 22 | |
| 23 | |
| 24 class ReviewerLgtmTest(mocks.TestCase): | |
| 25 def testNoMessage(self): | |
| 26 self.pending.reviewers = ['reviewer@example.com'] | |
| 27 self._check(reviewer_lgtm.LgtmStatus.NO_COMMENT) | |
| 28 | |
| 29 def testLgtmOwner(self): | |
| 30 self.pending.messages = [ | |
| 31 {'approval': True, 'sender': self.pending.owner} | |
| 32 ] | |
| 33 self.pending.reviewers = [self.pending.owner] | |
| 34 self._check(reviewer_lgtm.LgtmStatus.NO_LGTM) | |
| 35 | |
| 36 def testLgtmOk(self): | |
| 37 self.pending.messages = [ | |
| 38 {'approval': True, 'sender': 'reviewer@example.com'} ] | |
| 39 self.pending.reviewers = ['reviewer@example.com'] | |
| 40 self._check(None) | |
| 41 | |
| 42 def testLgtmWrongDomain(self): | |
| 43 self.pending.messages = [ | |
| 44 {'approval': True, 'sender': 'georges@example2.com'} ] | |
| 45 self.pending.reviewers = ['georges@example2.com'] | |
| 46 self._check(reviewer_lgtm.LgtmStatus.NO_LGTM) | |
| 47 | |
| 48 def testLgtmBlacklist(self): | |
| 49 self.pending.messages = [ | |
| 50 { | |
| 51 'approval': False, 'text': 'fix your stuff', | |
| 52 'sender': 'reviewer@example.com' | |
| 53 }, | |
| 54 {'approval': True, 'sender': 'commit-bot@example.com'}, | |
| 55 ] | |
| 56 self.pending.reviewers = ['reviewer@example.com', 'commit-bot@example.com'] | |
| 57 self._check(reviewer_lgtm.LgtmStatus.NO_LGTM) | |
| 58 | |
| 59 def testTBR(self): | |
| 60 self.pending.description = 'Webkit roll\nTBR=' | |
| 61 self._check(None) | |
| 62 | |
| 63 def _check(self, error_message): | |
| 64 ver = reviewer_lgtm.ReviewerLgtmVerifier( | |
| 65 [r'^[\-\w]+\@example\.com$'], | |
| 66 [re.escape('commit-bot@example.com')]) | |
| 67 ver.verify(self.pending) | |
| 68 ver.update_status([self.pending]) | |
| 69 name = reviewer_lgtm.ReviewerLgtmVerifier.name | |
| 70 self.assertEqual( | |
| 71 self.pending.verifications.keys(), [name]) | |
| 72 self.assertEqual( | |
| 73 self.pending.verifications[name].error_message, error_message) | |
| 74 if error_message: | |
| 75 self.assertEqual( | |
| 76 self.pending.verifications[name].get_state(), base.FAILED) | |
| 77 else: | |
| 78 self.assertEqual( | |
| 79 self.pending.verifications[name].get_state(), base.SUCCEEDED) | |
| 80 | |
| 81 | |
| 82 if __name__ == '__main__': | |
| 83 logging.basicConfig( | |
| 84 level=[logging.WARNING, logging.INFO, logging.DEBUG][ | |
| 85 min(sys.argv.count('-v'), 2)], | |
| 86 format='%(levelname)5s %(module)15s(%(lineno)3d): %(message)s') | |
| 87 unittest.main() | |
| OLD | NEW |
|---|
Chromium Code Reviews
Issue 135363007:
Delete public commit queue to avoid confusion after move to internal repo (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/tools/