Chromium Code Reviews

Issue 135363004: MediaStream API: Patch #1 of implementing navigator.getMediaDevices (Closed)

Created:
6 years, 10 months ago by Tommy Widenflycht
Modified:
6 years, 10 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, philipj_slow, dglazkov+blink, eric.carlson_apple.com, abarth-chromium, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

MediaStream API: Patch #1 of implementing navigator.getMediaDevices The deprecated MediaStreamTrack.getSources() will be removed later. This patch contains almost everything except .idl files which means that this is "dead" code which will not affect anything. Patch 2 will introduce mock support for getMediaDevices. And finally the third patch will add tests and idl files. BUG=338511 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166370

Patch Set 1 #

Patch Set 2 : Fixed year #

Unified diffs Side-by-side diffs Stats (+483 lines, -146 lines)
A + Source/modules/mediastream/MediaDeviceInfo.h View 2 chunks +12 lines, -13 lines 0 comments
A + Source/modules/mediastream/MediaDeviceInfo.cpp View 2 chunks +21 lines, -32 lines 0 comments
A + Source/modules/mediastream/MediaDeviceInfoCallback.h View 2 chunks +10 lines, -13 lines 0 comments
A + Source/modules/mediastream/MediaDevicesRequest.h View 2 chunks +26 lines, -23 lines 0 comments
A Source/modules/mediastream/MediaDevicesRequest.cpp View 1 chunk +83 lines, -0 lines 0 comments
M Source/modules/mediastream/NavigatorMediaStream.h View 2 chunks +3 lines, -0 lines 0 comments
M Source/modules/mediastream/NavigatorMediaStream.cpp View 2 chunks +19 lines, -0 lines 0 comments
M Source/modules/mediastream/UserMediaClient.h View 2 chunks +3 lines, -0 lines 0 comments
M Source/modules/mediastream/UserMediaController.h View 3 chunks +15 lines, -0 lines 0 comments
M Source/modules/modules.gypi View 1 chunk +5 lines, -0 lines 0 comments
M Source/platform/blink_platform.gypi View 1 chunk +1 line, -0 lines 0 comments
A Source/platform/exported/WebMediaDeviceInfo.cpp View 1 chunk +107 lines, -0 lines 0 comments
M Source/web/UserMediaClientImpl.h View 2 chunks +3 lines, -1 line 0 comments
M Source/web/UserMediaClientImpl.cpp View 2 chunks +13 lines, -1 line 0 comments
A Source/web/WebMediaDevicesRequest.cpp View 1 chunk +99 lines, -0 lines 0 comments
M Source/web/web.gypi View 1 chunk +1 line, -0 lines 0 comments
A + public/platform/WebMediaDeviceInfo.h View 3 chunks +20 lines, -26 lines 0 comments
A + public/web/WebMediaDevicesRequest.h View 2 chunks +39 lines, -36 lines 0 comments
M public/web/WebUserMediaClient.h View 2 chunks +3 lines, -1 line 0 comments

Messages

Total messages: 12 (0 generated)
Tommy Widenflycht
6 years, 10 months ago (2014-01-29 00:26:50 UTC) #1
Tommy Widenflycht
PING?
6 years, 10 months ago (2014-02-03 14:17:03 UTC) #2
abarth-chromium
lgtm
6 years, 10 months ago (2014-02-03 21:09:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommyw@chromium.org/135363004/20001
6 years, 10 months ago (2014-02-03 21:09:18 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-03 22:51:24 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=20092
6 years, 10 months ago (2014-02-03 22:51:24 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 22:51:27 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 22:51:32 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 22:54:15 UTC) #9
Tommy Widenflycht
The CQ bit was checked by tommyw@chromium.org
6 years, 10 months ago (2014-02-04 07:52:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommyw@chromium.org/135363004/20001
6 years, 10 months ago (2014-02-04 07:52:50 UTC) #11
commit-bot: I haz the power
6 years, 10 months ago (2014-02-04 08:51:36 UTC) #12
Message was sent while issue was closed. 
Change committed as 166370

Powered by Google App Engine