Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 1353603003: [Android] Remove old gtest test_runner code. (Closed)

Created:
5 years, 3 months ago by jbudorick
Modified:
5 years, 3 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Remove old gtest test_runner code. BUG=428729 Committed: https://crrev.com/9227d865c8b4eb0c10086efe4213c9f84457ee03 Cr-Commit-Position: refs/heads/master@{#349694}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -989 lines) Patch
M build/all.gyp View 1 chunk +1 line, -3 lines 0 comments Download
M build/android/buildbot/bb_device_steps.py View 5 chunks +43 lines, -5 lines 0 comments Download
D build/android/pylib/gtest/gtest_config.py View 1 chunk +0 lines, -54 lines 0 comments Download
D build/android/pylib/gtest/setup.py View 1 chunk +0 lines, -229 lines 0 comments Download
D build/android/pylib/gtest/test_options.py View 1 chunk +0 lines, -19 lines 0 comments Download
D build/android/pylib/gtest/test_package.py View 1 chunk +0 lines, -80 lines 0 comments Download
D build/android/pylib/gtest/test_package_apk.py View 1 chunk +0 lines, -171 lines 0 comments Download
D build/android/pylib/gtest/test_package_exe.py View 1 chunk +0 lines, -163 lines 0 comments Download
D build/android/pylib/gtest/test_runner.py View 1 chunk +0 lines, -218 lines 0 comments Download
M build/android/test_runner.py View 3 chunks +1 line, -47 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
jbudorick
KABOOM
5 years, 3 months ago (2015-09-17 23:30:16 UTC) #2
mikecase (-- gone --)
lgtm
5 years, 3 months ago (2015-09-18 00:19:57 UTC) #3
jbudorick
On 2015/09/18 at 00:19:57, mikecase wrote: > lgtm going to let the previous CL settle ...
5 years, 3 months ago (2015-09-18 00:23:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1353603003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1353603003/20001
5 years, 3 months ago (2015-09-18 15:14:04 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-18 16:39:57 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/9227d865c8b4eb0c10086efe4213c9f84457ee03 Cr-Commit-Position: refs/heads/master@{#349694}
5 years, 3 months ago (2015-09-18 16:40:41 UTC) #9
dgrogan
Findit suspects that this CL caused a ton of android test failures, e.g. below. Could ...
5 years, 3 months ago (2015-09-18 18:41:35 UTC) #11
jbudorick
On 2015/09/18 at 18:41:35, dgrogan wrote: > Findit suspects that this CL caused a ton ...
5 years, 3 months ago (2015-09-18 18:44:04 UTC) #12
jbudorick
5 years, 3 months ago (2015-09-18 18:56:19 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1354213004/ by jbudorick@chromium.org.

The reason for reverting is: need to revert predecessor.

Powered by Google App Engine
This is Rietveld 408576698