Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1353553002: Create append methods in batch namespaces (Closed)

Created:
5 years, 3 months ago by joshua.litt
Modified:
5 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Create append methods in batch namespaces BUG=skia: Committed: https://skia.googlesource.com/skia/+/aa37a96d554c5be7907ce04ee1ef843d0521eafb

Patch Set 1 #

Patch Set 2 : tweaks #

Total comments: 8

Patch Set 3 : Rob's feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -91 lines) Patch
M src/gpu/batches/GrAAFillRectBatch.h View 1 2 chunks +14 lines, -0 lines 0 comments Download
M src/gpu/batches/GrAAFillRectBatch.cpp View 1 2 4 chunks +49 lines, -11 lines 0 comments Download
M src/gpu/batches/GrAAStrokeRectBatch.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M src/gpu/batches/GrAAStrokeRectBatch.cpp View 1 7 chunks +59 lines, -24 lines 0 comments Download
M src/gpu/batches/GrNonAAFillRectBatch.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/gpu/batches/GrNonAAFillRectBatch.cpp View 1 2 4 chunks +72 lines, -19 lines 0 comments Download
M src/gpu/batches/GrNonAAStrokeRectBatch.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/gpu/batches/GrNonAAStrokeRectBatch.cpp View 1 5 chunks +56 lines, -29 lines 0 comments Download
M src/gpu/batches/GrTInstanceBatch.h View 1 2 2 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
joshualitt
Robert, how much do you hate this?
5 years, 3 months ago (2015-09-16 19:22:54 UTC) #2
joshualitt
ptal
5 years, 3 months ago (2015-09-18 16:37:17 UTC) #3
robertphillips
https://codereview.chromium.org/1353553002/diff/20001/src/gpu/batches/GrAAFillRectBatch.cpp File src/gpu/batches/GrAAFillRectBatch.cpp (right): https://codereview.chromium.org/1353553002/diff/20001/src/gpu/batches/GrAAFillRectBatch.cpp#newcode290 src/gpu/batches/GrAAFillRectBatch.cpp:290: "inline" these to document our hopes & prayers ? ...
5 years, 3 months ago (2015-09-18 17:42:26 UTC) #4
joshualitt
feedback incorporated https://codereview.chromium.org/1353553002/diff/20001/src/gpu/batches/GrAAFillRectBatch.cpp File src/gpu/batches/GrAAFillRectBatch.cpp (right): https://codereview.chromium.org/1353553002/diff/20001/src/gpu/batches/GrAAFillRectBatch.cpp#newcode290 src/gpu/batches/GrAAFillRectBatch.cpp:290: On 2015/09/18 17:42:25, robertphillips wrote: > "inline" ...
5 years, 3 months ago (2015-09-18 18:34:11 UTC) #5
robertphillips
lgtm
5 years, 3 months ago (2015-09-18 19:49:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1353553002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1353553002/40001
5 years, 3 months ago (2015-09-18 19:57:39 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 20:03:27 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/aa37a96d554c5be7907ce04ee1ef843d0521eafb

Powered by Google App Engine
This is Rietveld 408576698