Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8017)

Unified Diff: chrome/browser/resources/settings/on_startup_page/startup_urls_page.js

Issue 1353453003: [MD settings] fixes for OnStartup using the closure compiler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review nit Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/on_startup_page/compiled_resources.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
diff --git a/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js b/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
index 3d45fe2411b837f65be5c16203ee8b9aa3c667fe..fd5e903f78717c887d0936d39d56b1a850b5f622 100644
--- a/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
+++ b/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
@@ -44,19 +44,24 @@ Polymer({
],
attached: function() {
- var updateFunction = this.updateStartupPages_.bind(this);
+ var self = this;
cr.define('Settings', function() {
return {
- updateStartupPages: updateFunction,
+ updateStartupPages: function() {
+ return self.updateStartupPages_.apply(self, arguments);
+ },
};
});
},
+
/** @private */
prefsChanged_: function(change) {
- if (this.savedUrlList == undefined &&
- this.get('prefs.session.startup_urls')) {
- this.savedUrlList = this.prefs.session.startup_urls.value.slice();
+ if (!this.savedUrlList) {
+ var pref = /** @type {chrome.settingsPrivate.PrefObject} */(
+ this.get('prefs.session.startup_urls'));
+ if (pref)
+ this.savedUrlList = pref.value.slice();
}
},
« no previous file with comments | « chrome/browser/resources/settings/on_startup_page/compiled_resources.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698