[MD settings] fixes for OnStartup using the closure compiler

chrome/browser/resources/settings/on_startup_page/startup_urls_page.js

Index: chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
diff --git a/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js b/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
index 3d45fe2411b837f65be5c16203ee8b9aa3c667fe..bf9bbede3049a74c378fb31381802cd9d13f4558 100644
--- a/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
+++ b/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
@@ -44,20 +44,23 @@ Polymer({
   ],
 
   attached: function() {
-    var updateFunction = this.updateStartupPages_.bind(this);
+    var self = this;
     cr.define('Settings', function() {
       return {
-        updateStartupPages: updateFunction,
+        updateStartupPages: function() {
+          return self.updateStartupPages_.apply(self, arguments);
+        },
       };
     });
   },
 
+
   /** @private */
   prefsChanged_: function(change) {
-    if (this.savedUrlList == undefined &&
-        this.get('prefs.session.startup_urls')) {
-      this.savedUrlList = this.prefs.session.startup_urls.value.slice();
-    }
+    var pref = /** @type {chrome.settingsPrivate.PrefObject} */(
+        this.get('prefs.session.startup_urls'));
+    if (!this.savedUrlList && pref)
+      this.savedUrlList = pref.value.slice();

[Dan Beam, 2015/09/18 19:05:53]

nit: try to use variables as close as you can to where they're declared.  in
this case, the optimal code (for never doing any needless work) is, imo:

if (!this.savedUrlList) {
  var pref = this.get('prefs.session.startup_urls');
  if (pref)
    this.savedUrlList = pref.value.slice();
}

or

if (this.savedUrlList)
  return;

var pref = this.get('prefs.session.startup_urls');
if (pref)
  this.savedUrlList = pref.value.slice();

   },
 
   /** @private */