[MD settings] fixes for OnStartup using the closure compiler

chrome/browser/resources/settings/on_startup_page/startup_urls_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview 'cr-settings-startup-urls-page' is the settings page
  * containing the urls that will be opened when chrome is started.
  *
  * Example:
  *
@@ skipping 28 matching lines @@
     },
   },
 
   observers: [
     'prefsChanged_(prefs.session.startup_urls.value.*)',
   ],
 
   attached: function() {
     var updateFunction = this.updateStartupPages_.bind(this);
     cr.define('Settings', function() {
+      var localFunction = updateFunction;
       return {
-        updateStartupPages: updateFunction,
+        updateStartupPages: localFunction,

[Dan Beam, 2015/09/18 03:12:23]

this is probably some chrome-specific compiler pass nonsense

[dschuyler, 2015/09/18 17:31:13]

Acknowledged.

       };

[Dan Beam, 2015/09/18 03:12:23]

does this work?

var self = this;

cr.define('Settings', function() {
  return {
    updateStartupPages: function() {
      return self.updateStartupPages_.apply(self, arguments);
    },
  };
});

[dschuyler, 2015/09/18 17:31:13]

Yes, the closure compiler is happy with that.

Done.

     });
   },
 
+
   /** @private */
   prefsChanged_: function(change) {
-    if (this.savedUrlList == undefined &&
-        this.get('prefs.session.startup_urls')) {
-      this.savedUrlList = this.prefs.session.startup_urls.value.slice();
+    var pref = /** @type {chrome.settingsPrivate.PrefObject} */(
+        this.get('prefs.session.startup_urls'));
+    if (this.savedUrlList == undefined && pref) {

[Dan Beam, 2015/09/18 03:12:23]

nit: !this.savedUrlList instead of == undefined

[Dan Beam, 2015/09/18 03:12:23]

nit: no curlies

[dschuyler, 2015/09/18 17:31:13]

Done.

[dschuyler, 2015/09/18 17:31:13]

Done.

+      this.savedUrlList = pref.value.slice();
     }
   },
 
   /** @private */
   updateStartupPages_: function(data) {
     var urlArray = [];
     for (var i = 0; i < data.length; ++i)
       urlArray.push(data[i].url);
     this.set('prefs.session.startup_urls.value', urlArray);
   },
@@ skipping 20 matching lines @@
   },
 
   /**
    * @param {!{model: !{index: number}}} e
    * @private
    */
   onRemoveUrlTap_: function(e) {
     this.splice('prefs.session.startup_urls.value', e.model.index, 1);
   },
 });