Issue 13534002: History: Prevent entries from taking up all the available space.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13534002: History: Prevent entries from taking up all the available space. (Closed)

Created:
7 years, 8 months ago by Sergiu

Modified:
7 years, 8 months ago

Reviewers:
Patrick Dubroy

CC:
chromium-reviews, Patrick Dubroy, pam+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

History: Prevent entries from taking up all the available space. Before the link entry would extend as much as it could to the right, this patch prevents that and restores the previous behavior. This is done by moving the div that contains the managed mode indicators (which are not shown normally anyways) one level up in the DOM and making that div take up available the space. R=dubroy@chromium.org BUG=224081 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192295

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/resources/history/history.css	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/browser/resources/history/history.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergiu@chromium.org/13534002/1

7 years, 8 months ago (2013-04-03 13:16:32 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=130607

7 years, 8 months ago (2013-04-03 19:01:06 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergiu@chromium.org/13534002/1

7 years, 8 months ago (2013-04-04 07:54:08 UTC) #5

Message was sent while issue was closed.

Change committed as 192295

Expand Messages | Collapse Messages