Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: sync/android/java/src/org/chromium/sync/signin/AccountManagerHelper.java

Issue 1353393002: Mask the AccountManager{Future,Callback} with a simple Callback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rmcas
Patch Set: fix test. move background task to where it is required. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/android/java/src/org/chromium/sync/signin/AccountManagerHelper.java
diff --git a/sync/android/java/src/org/chromium/sync/signin/AccountManagerHelper.java b/sync/android/java/src/org/chromium/sync/signin/AccountManagerHelper.java
index 7c1026784698ea429123ff899a2e94ece3bfb75b..ce696aa8cf704349349465f826656e66986a64b6 100644
--- a/sync/android/java/src/org/chromium/sync/signin/AccountManagerHelper.java
+++ b/sync/android/java/src/org/chromium/sync/signin/AccountManagerHelper.java
@@ -8,7 +8,6 @@ package org.chromium.sync.signin;
import android.Manifest;
import android.accounts.Account;
import android.accounts.AccountManager;
-import android.accounts.AccountManagerCallback;
import android.accounts.AccountManagerFuture;
import android.accounts.AuthenticatorDescription;
import android.accounts.AuthenticatorException;
@@ -166,16 +165,8 @@ public class AccountManagerHelper {
return mAccountManager.getAccountsByType(GOOGLE_ACCOUNT_TYPE);
}
- /**
- * Convenience method to get the single Google account on the device. Should only be
- * called if it has been determined that there is exactly one account.
- *
- * @return The single account to sign into.
- */
- public Account getSingleGoogleAccount() {
- Account[] googleAccounts = getGoogleAccounts();
- assert googleAccounts.length == 1;
- return googleAccounts[0];
+ public void getGoogleAccounts(AccountManagerDelegate.Callback<Account[]> callback) {
+ mAccountManager.getAccountsByType(GOOGLE_ACCOUNT_TYPE, callback);
}
public boolean hasGoogleAccounts() {
@@ -382,9 +373,9 @@ public class AccountManagerHelper {
}
}
- public AccountManagerFuture<Boolean> checkChildAccount(
- Account account, AccountManagerCallback<Boolean> callback) {
+ public void checkChildAccount(
+ Account account, AccountManagerDelegate.Callback<Boolean> callback) {
String[] features = {FEATURE_IS_CHILD_ACCOUNT_KEY};
- return mAccountManager.hasFeatures(account, features, callback, null /* handler */);
+ mAccountManager.hasFeatures(account, features, callback);
}
}

Powered by Google App Engine
This is Rietveld 408576698