chrome/android/java/src/org/chromium/chrome/browser/services/AndroidEduAndChildAccountHelper.java - Issue 1353393002: Mask the AccountManager{Future,Callback} with a simple Callback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/services/AndroidEduAndChildAccountHelper.java

Issue 1353393002: Mask the AccountManager{Future,Callback} with a simple Callback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rmcas

Patch Set: fix test. move background task to where it is required. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/childaccounts/ChildAccountService.java ('k') | components/signin/core/browser/android/java/src/org/chromium/components/signin/ChildAccountInfoFetcher.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/services/AndroidEduAndChildAccountHelper.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/services/AndroidEduAndChildAccountHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/services/AndroidEduAndChildAccountHelper.java

index ef6db47860a64d34bca084a7ee742bce22f13346..87b20a0f085215c575699268bfc17a16e8e4fe62 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/services/AndroidEduAndChildAccountHelper.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/services/AndroidEduAndChildAccountHelper.java

@@ -9,6 +9,7 @@ import android.content.Context;

import org.chromium.base.Log;

import org.chromium.chrome.browser.ChromeApplication;

import org.chromium.chrome.browser.childaccounts.ChildAccountService;

+import org.chromium.sync.signin.AccountManagerDelegate.Callback;

/**

* A helper for Android EDU and child account checks.

@@ -16,7 +17,7 @@ import org.chromium.chrome.browser.childaccounts.ChildAccountService;

* new AndroidEduAndChildAccountHelper() { override onParametersReady() }.start(appContext).

public abstract class AndroidEduAndChildAccountHelper

- implements ChildAccountService.HasChildAccountCallback, AndroidEduOwnerCheckCallback {

+ implements Callback<Boolean>, AndroidEduOwnerCheckCallback {

private Boolean mIsAndroidEduDevice;

private Boolean mHasChildAccount;

// Abbreviated to < 20 chars.

@@ -62,9 +63,9 @@ public abstract class AndroidEduAndChildAccountHelper

checkDone();

}

- // ChildAccountManager.HasChildAccountCallback:

+ // AccountManagerDelegate.Callback<Boolean>:

@Override

- public void onChildAccountChecked(boolean hasChildAccount) {

+ public void gotResult(Boolean hasChildAccount) {

Log.d(TAG, "onChildAccountChecked");

mHasChildAccount = hasChildAccount;

checkDone();