tools/dartium/upload_steps.py - Issue 1353373002: Fix obsolete gsutil command in scripts. Delete editor signing script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dartium/upload_steps.py

Issue 1353373002: Fix obsolete gsutil command in scripts. Delete editor signing script. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address comment. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/dartium/upload_steps.py

diff --git a/tools/dartium/upload_steps.py b/tools/dartium/upload_steps.py

index 8665f843928a9c3fe47c015d28ae41a09446f9df..2ab3fc8c722558f065aca2102d95e0011d2275be 100755

--- a/tools/dartium/upload_steps.py

+++ b/tools/dartium/upload_steps.py

@@ -192,7 +192,7 @@ def OldUploadFile(source, target):

# Set ACL.

if ACL is not None:

- cmd = [GSUTIL, 'setacl', ACL, target]

+ cmd = [GSUTIL, 'acl', 'set', ACL, target]

(status, output) = ExecuteCommand(cmd)

return status

« no previous file with comments | « tools/bots/cross-vm.py ('k') | tools/signing_script.py » ('j') | no next file with comments »