tools/bots/cross-vm.py - Issue 1353373002: Fix obsolete gsutil command in scripts. Delete editor signing script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/bots/cross-vm.py

Issue 1353373002: Fix obsolete gsutil command in scripts. Delete editor signing script. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/bots/cross-vm.py

diff --git a/tools/bots/cross-vm.py b/tools/bots/cross-vm.py

index 1296fe920517b9daa06fcb75af65c66a2affb964..28d06810dd7d8590d579d3ed5fc347484d93f11d 100644

--- a/tools/bots/cross-vm.py

+++ b/tools/bots/cross-vm.py

@@ -52,7 +52,7 @@ def cross_compiling_builder(arch, mode):

with bot.BuildStep('Upload build tarball'):

uri = "%s/%s" % (GCS_BUCKET, tarball)

run([GSUTIL, 'cp', tarball, uri])

ricow1 2015/09/21 10:13:25 cp -a public-read?

Bill Hesse 2015/09/21 10:18:29 Done.

- run([GSUTIL, 'setacl', 'public-read', uri])

+ run([GSUTIL, 'acl', 'set', 'public-read', uri])

elif num_run == 2:

with bot.BuildStep('tests'):

« no previous file with comments | « no previous file | tools/dartium/upload_steps.py » ('j') | no next file with comments »