src/heap/mark-compact.cc - Issue 1353363002: Share literals arrays per <NativeContext, SharedFunctionInfo> pair.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/mark-compact.cc

Issue 1353363002: Share literals arrays per <NativeContext, SharedFunctionInfo> pair. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressing comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/mark-compact.cc

diff --git a/src/heap/mark-compact.cc b/src/heap/mark-compact.cc

index 9f5ac52028ae2bda5a16c8cb8d2c62adb03a821c..f30c2df8e77fb2205e5c7fcf8a8f7c3a0c6b3977 100644

--- a/src/heap/mark-compact.cc

+++ b/src/heap/mark-compact.cc

@@ -1013,8 +1013,8 @@ void CodeFlusher::ProcessOptimizedCodeMaps() {

STATIC_ASSERT(SharedFunctionInfo::kEntryLength == 4);

Context* context =

Context::cast(code_map->get(i + SharedFunctionInfo::kContextOffset));

- Code* code =

- Code::cast(code_map->get(i + SharedFunctionInfo::kCachedCodeOffset));

+ HeapObject* code = HeapObject::cast(

+ code_map->get(i + SharedFunctionInfo::kCachedCodeOffset));

FixedArray* literals = FixedArray::cast(

code_map->get(i + SharedFunctionInfo::kLiteralsOffset));

Smi* ast_id =

« no previous file with comments | « src/factory.cc ('k') | src/objects.h » ('j') | no next file with comments »