Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1353343002: X87: [runtime] Replace COMPARE/COMPARE_STRONG with proper Object::Compare. (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [runtime] Replace COMPARE/COMPARE_STRONG with proper Object::Compare. port 593c655a3c814277283f9fa1520d5ce59d6b019c (r30816). original commit message: This removes the weird COMPARE and COMPARE_STRONG JavaScript builtins and replaces them with a proper C++ implementation in Object::Compare and appropriate wrappers Object::LessThan, Object::GreaterThan, and friends that are intended to be used by a true/false returning CompareIC in the future, as well as the interpreter. As a short-term solution we provide %Compare and %Compare_Strong entry points for the current CompareIC that return the appropriate integer values expected by fullcodegen currently. Now the Abstract Relational Comparison is also using the correct ToPrimitive implementation, which properly supports @@toPrimitive. BUG= Committed: https://crrev.com/9155967e84718f100119539136c9b37e9c5fbcf0 Cr-Commit-Position: refs/heads/master@{#30844}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M src/x87/code-stubs-x87.cc View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 3 months ago (2015-09-21 02:25:13 UTC) #2
Weiliang
lgtm
5 years, 3 months ago (2015-09-21 08:49:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1353343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1353343002/1
5 years, 3 months ago (2015-09-21 08:50:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-21 09:13:09 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 09:13:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9155967e84718f100119539136c9b37e9c5fbcf0
Cr-Commit-Position: refs/heads/master@{#30844}

Powered by Google App Engine
This is Rietveld 408576698