Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: courgette/ensemble_unittest.cc

Issue 1353333002: Cleanup: Pass std::string as const reference from courgette/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: courgette/ensemble_unittest.cc
diff --git a/courgette/ensemble_unittest.cc b/courgette/ensemble_unittest.cc
index b255ae94c1ccc1379ccfa1d2ccce8b6d79d3bc86..9b4c2dd9a5c073be0fab0091ebb473a54685058a 100644
--- a/courgette/ensemble_unittest.cc
+++ b/courgette/ensemble_unittest.cc
@@ -20,17 +20,16 @@
class EnsembleTest : public BaseTest {
public:
-
- void TestEnsemble(std::string src_bytes, std::string tgt_bytes) const;
+ void TestEnsemble(const std::string& src_bytes,
+ const std::string& tgt_bytes) const;
void PeEnsemble() const;
void Pe64Ensemble() const;
void Elf32Ensemble() const;
};
-void EnsembleTest::TestEnsemble(std::string src_bytes,
- std::string tgt_bytes) const {
-
+void EnsembleTest::TestEnsemble(const std::string& src_bytes,
+ const std::string& tgt_bytes) const {
courgette::SourceStream source;
courgette::SourceStream target;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698