Cleanup: Pass std::string as const reference from rlz/

rlz/chromeos/lib/rlz_value_store_chromeos.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "rlz/chromeos/lib/rlz_value_store_chromeos.h"
 
 #include "base/base_paths.h"
 #include "base/files/file_util.h"
 #include "base/files/important_file_writer.h"
 #include "base/json/json_file_value_serializer.h"
@@ skipping 43 matching lines @@
 // Returns file path of the RLZ storage lock file.
 base::FilePath GetRlzStoreLockPath() {
   base::FilePath homedir;
   PathService::Get(base::DIR_HOME, &homedir);
   return g_testing_rlz_store_path_.empty() ?
       homedir.Append(kRLZLockFileName) :
       g_testing_rlz_store_path_.Append(kRLZLockFileName);
 }
 
 // Returns the dictionary key for storing access point-related prefs.
-std::string GetKeyName(std::string key, AccessPoint access_point) {
+std::string GetKeyName(const std::string& key, AccessPoint access_point) {
   std::string brand = SupplementaryBranding::GetBrand();
   if (brand.empty())
     brand = kNoSupplementaryBrand;
   return key + "." + GetAccessPointName(access_point) + "." + brand;
 }
 
 // Returns the dictionary key for storing product-related prefs.
-std::string GetKeyName(std::string key, Product product) {
+std::string GetKeyName(const std::string& key, Product product) {
   std::string brand = SupplementaryBranding::GetBrand();
   if (brand.empty())
     brand = kNoSupplementaryBrand;
   return key + "." + GetProductName(product) + "." + brand;
 }
 
 }  // namespace
 
 RlzValueStoreChromeOS::RlzValueStoreChromeOS(const base::FilePath& store_path)
     : rlz_store_(new base::DictionaryValue),
@@ skipping 152 matching lines @@
       rlz_store_->DeepCopyWithoutEmptyChildren();
   if (!serializer.Serialize(*copy.get())) {
     LOG(ERROR) << "Failed to serialize RLZ data";
     NOTREACHED();
     return;
   }
   if (!base::ImportantFileWriter::WriteFileAtomically(store_path_, json_data))
     LOG(ERROR) << "Error writing RLZ store";
 }
 
-bool RlzValueStoreChromeOS::AddValueToList(std::string list_name,
+bool RlzValueStoreChromeOS::AddValueToList(const std::string& list_name,
                                            base::Value* value) {
   base::ListValue* list_value = NULL;
   if (!rlz_store_->GetList(list_name, &list_value)) {
     list_value = new base::ListValue;
     rlz_store_->Set(list_name, list_value);
   }
   list_value->AppendIfNotPresent(value);
   return true;
 }
 
-bool RlzValueStoreChromeOS::RemoveValueFromList(std::string list_name,
+bool RlzValueStoreChromeOS::RemoveValueFromList(const std::string& list_name,
                                                 const base::Value& value) {
   base::ListValue* list_value = NULL;
   if (!rlz_store_->GetList(list_name, &list_value))
     return false;
   size_t index;
   list_value->Remove(value, &index);
   return true;
 }
 
 namespace {
@@ skipping 66 matching lines @@
   g_testing_rlz_store_path_ = directory;
 }
 
 std::string RlzStoreFilenameStr() {
   return GetRlzStorePath().value();
 }
 
 }  // namespace testing
 
 }  // namespace rlz_lib