Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: chromeos/network/onc/onc_certificate_importer_impl_unittest.cc

Issue 1353323002: Cleanup: Pass std::string as const reference from chromeos/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Don't use const& for NetworkConnectionHandler::CheckPendingRequest; Use one more const& in unittests Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/network/network_connection_handler.h ('k') | chromeos/network/shill_property_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/onc/onc_certificate_importer_impl_unittest.cc
diff --git a/chromeos/network/onc/onc_certificate_importer_impl_unittest.cc b/chromeos/network/onc/onc_certificate_importer_impl_unittest.cc
index 35ff424149eec34d2566c132de663842e0f61632..caa5ed8c942be0dd23964dbd9bd43825cbf1fcdd 100644
--- a/chromeos/network/onc/onc_certificate_importer_impl_unittest.cc
+++ b/chromeos/network/onc/onc_certificate_importer_impl_unittest.cc
@@ -97,7 +97,8 @@ class ONCCertificateImporterImplTest : public testing::Test {
web_trust_certificates_ = onc_trusted_certificates;
}
- void AddCertificatesFromFile(std::string filename, bool expected_success) {
+ void AddCertificatesFromFile(const std::string& filename,
+ bool expected_success) {
scoped_ptr<base::DictionaryValue> onc =
test_utils::ReadTestDictionary(filename);
scoped_ptr<base::Value> certificates_value;
@@ -122,7 +123,7 @@ class ONCCertificateImporterImplTest : public testing::Test {
private_list_ = ListCertsInPrivateSlot();
}
- void AddCertificateFromFile(std::string filename,
+ void AddCertificateFromFile(const std::string& filename,
net::CertType expected_type,
std::string* guid) {
std::string guid_temporary;
« no previous file with comments | « chromeos/network/network_connection_handler.h ('k') | chromeos/network/shill_property_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698