Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1353313002: Make drawbitmaprect GM use Ganesh-backed bitmaps and images (Closed)

Created:
5 years, 3 months ago by robertphillips
Modified:
5 years, 3 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make drawbitmaprect GM use Ganesh-backed bitmaps and images This is left over from trying to repro Android not serializing Ganesh-backed bitmaps Committed: https://skia.googlesource.com/skia/+/24eb7a8ed04db40cec68d215f5b2c646777f254c

Patch Set 1 #

Patch Set 2 : Update? #

Patch Set 3 : Clean up #

Patch Set 4 : more clean up #

Patch Set 5 : Rm unused function #

Patch Set 6 : Fix no-GPU build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -15 lines) Patch
M gm/drawbitmaprect.cpp View 1 2 3 4 5 4 chunks +41 lines, -15 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
robertphillips
5 years, 3 months ago (2015-09-20 17:22:41 UTC) #1
robertphillips
5 years, 3 months ago (2015-09-24 15:25:29 UTC) #3
bsalomon
lgtm
5 years, 3 months ago (2015-09-24 15:29:25 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1353313002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1353313002/60001
5 years, 3 months ago (2015-09-24 15:31:33 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mips-Debug-Android-Trybot/builds/2649) Build-Ubuntu-GCC-x86_64-Release-Trybot on ...
5 years, 3 months ago (2015-09-24 15:32:18 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1353313002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1353313002/80001
5 years, 3 months ago (2015-09-24 15:36:14 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/3337)
5 years, 3 months ago (2015-09-24 15:37:04 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1353313002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1353313002/100001
5 years, 3 months ago (2015-09-24 15:40:44 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-24 15:45:34 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1353313002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1353313002/100001
5 years, 3 months ago (2015-09-24 15:47:13 UTC) #19
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 15:47:54 UTC) #20
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/24eb7a8ed04db40cec68d215f5b2c646777f254c

Powered by Google App Engine
This is Rietveld 408576698