Issue 13533026: initialize Ole so that RegisterDragDrop doesn't fail on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13533026: initialize Ole so that RegisterDragDrop doesn't fail on Windows (Closed)

Created:
7 years, 8 months ago by scottmg

Modified:
7 years, 8 months ago

Reviewers:
jam, xhwang

CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

initialize Ole so that RegisterDragDrop doesn't fail on Windows Fixes all AutofillDialogControllerTest which were failing on Windows. R=xhwang@chromium.org,jam@chromium.org BUG=227221 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192643

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc	View		2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jam

lgtm, although it's unfortunate that we don't knwow what triggered this, and that the tree ...

7 years, 8 months ago (2013-04-05 23:24:29 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r192643.

Expand Messages | Collapse Messages