Issue 13533022: Android: Provide a smaller list of files to be pushed for content_browsertests.

Issue 13533022: Android: Provide a smaller list of files to be pushed for content_browsertests. (Closed)

Created:
7 years, 8 months ago by nilesh

Modified:
7 years, 8 months ago

Reviewers:
frankf, newt (away)

CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Android: Provide a smaller list of files to be pushed for content_browsertests. BUG=138275 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192656

Patch Set 6 : Avoid pushing emptyfile, _HasAdbPushSucceeded fails #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -13 lines)			Patch
	M	build/android/pylib/gtest/test_runner.py	View	1 2 3 4 5	3 chunks	+81 lines, -13 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

frankf

lgtm https://codereview.chromium.org/13533022/diff/4002/build/android/pylib/gtest/test_runner.py File build/android/pylib/gtest/test_runner.py (right): https://codereview.chromium.org/13533022/diff/4002/build/android/pylib/gtest/test_runner.py#newcode303 build/android/pylib/gtest/test_runner.py:303: self.adb.WaitForSdCardReady(20) Why do we need to check for ...

7 years, 8 months ago (2013-04-05 22:14:14 UTC) #3

nilesh

https://codereview.chromium.org/13533022/diff/4002/build/android/pylib/gtest/test_runner.py File build/android/pylib/gtest/test_runner.py (right): https://codereview.chromium.org/13533022/diff/4002/build/android/pylib/gtest/test_runner.py#newcode303 build/android/pylib/gtest/test_runner.py:303: self.adb.WaitForSdCardReady(20) On 2013/04/05 22:14:14, frankf wrote: > Why do ...

7 years, 8 months ago (2013-04-05 22:16:19 UTC) #4

frankf

7 years, 8 months ago (2013-04-05 22:19:48 UTC) #5

nilesh

Committed patchset #6 manually as r192656 (presubmit successful).

7 years, 8 months ago (2013-04-06 00:01:28 UTC) #6

nilesh

7 years, 8 months ago (2013-04-06 05:25:25 UTC) #7

Message was sent while issue was closed.

On 2013/04/05 22:19:48, frankf wrote:
>
https://codereview.chromium.org/13533022/diff/4002/build/android/pylib/gtest/...
> File build/android/pylib/gtest/test_runner.py (right):
> 
>
https://codereview.chromium.org/13533022/diff/4002/build/android/pylib/gtest/...
> build/android/pylib/gtest/test_runner.py:303: self.adb.WaitForSdCardReady(20)
> Not really (it's just a 'adb shell ls /sdcard'), but you can easily remove
> duplication by combining the two for loops together.

Do you mean something like:
if test_data or optional_test_data:
  // make sure sdcard is ready
if test_data:
  // push data
if optional_test_data:
 // push data

Will be happy to make changes in another CL.

> 
> On 2013/04/05 22:16:19, nilesh wrote:
> > On 2013/04/05 22:14:14, frankf wrote:
> > > Why do we need to check for sdcard again here?
> > 
> > if a test only has optional data and no test_data. Is it expensive?

Expand Messages | Collapse Messages