ui/views/controls/button/checkbox.h - Issue 13533021: Fix uninitialized POD member |use_custom_insets_| to fix regression and coverity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/button/checkbox.h

Issue 13533021: Fix uninitialized POD member |use_custom_insets_| to fix regression and coverity (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/button/checkbox.h

diff --git a/ui/views/controls/button/checkbox.h b/ui/views/controls/button/checkbox.h

index 08d2c338d98db735a0e2882303011ad161f2f01d..a2d80ba52a4fd6c4db6782ebcf3469b545392839 100644

--- a/ui/views/controls/button/checkbox.h

+++ b/ui/views/controls/button/checkbox.h

@@ -18,7 +18,7 @@ class VIEWS_EXPORT CheckboxNativeThemeBorder

: public TextButtonNativeThemeBorder {

public:

explicit CheckboxNativeThemeBorder(views::NativeThemeDelegate* delegate)

- : TextButtonNativeThemeBorder(delegate) {}

+ : TextButtonNativeThemeBorder(delegate), use_custom_insets_(false) {}

sky 2013/04/05 21:10:00 nit: since the constructor wrapped wrap this to th

Dan Beam 2013/04/05 21:57:45 Done.

virtual ~CheckboxNativeThemeBorder() {}

// The insets apply to the whole view (checkbox + text), not just the square

« no previous file with comments | « no previous file | no next file » | no next file with comments »