Issue 13533021: Fix uninitialized POD member |use_custom_insets_| to fix regression and coverity

Issue 13533021: Fix uninitialized POD member |use_custom_insets_| to fix regression and coverity (Closed)

Created:
7 years, 8 months ago by Dan Beam

Modified:
7 years, 8 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, msw

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix uninitialized POD member |use_custom_insets_| to fix regression and coverity issue somewhere (I'm sure). R=sky@chromium.org BUG=224259 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192667

Patch Set 2 : . #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	ui/views/controls/button/checkbox.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/13533021/diff/1/ui/views/controls/button/checkbox.h File ui/views/controls/button/checkbox.h (right): https://codereview.chromium.org/13533021/diff/1/ui/views/controls/button/checkbox.h#newcode21 ui/views/controls/button/checkbox.h:21: : TextButtonNativeThemeBorder(delegate), use_custom_insets_(false) {} nit: since the constructor ...

7 years, 8 months ago (2013-04-05 21:10:00 UTC) #2

Dan Beam

https://codereview.chromium.org/13533021/diff/1/ui/views/controls/button/checkbox.h File ui/views/controls/button/checkbox.h (right): https://codereview.chromium.org/13533021/diff/1/ui/views/controls/button/checkbox.h#newcode21 ui/views/controls/button/checkbox.h:21: : TextButtonNativeThemeBorder(delegate), use_custom_insets_(false) {} On 2013/04/05 21:10:00, sky wrote: ...

7 years, 8 months ago (2013-04-05 21:57:44 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/13533021/4001

7 years, 8 months ago (2013-04-05 21:58:34 UTC) #4

Message was sent while issue was closed.

Change committed as 192667

Expand Messages | Collapse Messages