Test extension reloading behavior.

content/browser/browsing_instance.h

Index: content/browser/browsing_instance.h
diff --git a/content/browser/browsing_instance.h b/content/browser/browsing_instance.h
index 7a4b1a65fb3113720c50468c942e4adb0dfb98c8..e9d1532583a3d9bc338d2286a9411f8d1cd3a0a4 100644
--- a/content/browser/browsing_instance.h
+++ b/content/browser/browsing_instance.h
@@ -67,17 +67,17 @@ class CONTENT_EXPORT BrowsingInstance
   // Get the SiteInstance responsible for rendering the given URL.  Should
   // create a new one if necessary, but should not create more than one
   // SiteInstance per site.
-  SiteInstance* GetSiteInstanceForURL(const GURL& url);
+  SiteInstanceImpl* GetSiteInstanceForURL(const GURL& url);

[Matt Perry, 2013/04/04 20:54:26]

why change these?

[Jeffrey Yasskin, 2013/04/05 13:14:01]

No good reason anymore. I was thinking that I might want to keep the non-virtual
set_render_process_host_factory() on SiteInstanceImpl (and have the virtual
SetRenderProcessHostFactory delegate to it), and then if this returns
SiteInstanceImpl we can avoid the virtual call overhead, but I haven't kept that
method, so returning a more precise type doesn't really gain anything.

 
   // Adds the given SiteInstance to our map, to ensure that we do not create
   // another SiteInstance for the same site.
-  void RegisterSiteInstance(SiteInstance* site_instance);
+  void RegisterSiteInstance(SiteInstanceImpl* site_instance);
 
   // Removes the given SiteInstance from our map, after all references to it
   // have been deleted.  This means it is safe to create a new SiteInstance
   // if the user later visits a page from this site, within this
   // BrowsingInstance.
-  void UnregisterSiteInstance(SiteInstance* site_instance);
+  void UnregisterSiteInstance(SiteInstanceImpl* site_instance);
 
   friend class SiteInstanceImpl;
   friend class SiteInstance;
@@ -89,7 +89,7 @@ class CONTENT_EXPORT BrowsingInstance
 
  private:
   // Map of site to SiteInstance, to ensure we only have one SiteInstance per
-  typedef base::hash_map<std::string, SiteInstance*> SiteInstanceMap;
+  typedef base::hash_map<std::string, SiteInstanceImpl*> SiteInstanceMap;
 
   // Common browser context to which all SiteInstances in this BrowsingInstance
   // must belong.