Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "chrome/browser/extensions/extension_service_unittest.h" | 5 #include "chrome/browser/extensions/extension_service_unittest.h" |
| 6 | 6 |
| 7 #include <algorithm> | 7 #include <algorithm> |
| 8 #include <set> | 8 #include <set> |
| 9 #include <vector> | 9 #include <vector> |
| 10 | 10 |
| 11 #include "base/at_exit.h" | 11 #include "base/at_exit.h" |
| 12 #include "base/basictypes.h" | 12 #include "base/basictypes.h" |
| 13 #include "base/bind.h" | 13 #include "base/bind.h" |
| 14 #include "base/command_line.h" | 14 #include "base/command_line.h" |
| 15 #include "base/file_util.h" | 15 #include "base/file_util.h" |
| 16 #include "base/files/scoped_temp_dir.h" | 16 #include "base/files/scoped_temp_dir.h" |
| 17 #include "base/json/json_file_value_serializer.h" | 17 #include "base/json/json_file_value_serializer.h" |
| 18 #include "base/json/json_reader.h" | 18 #include "base/json/json_reader.h" |
| 19 #include "base/json/json_string_value_serializer.h" | 19 #include "base/json/json_string_value_serializer.h" |
| 20 #include "base/memory/scoped_ptr.h" | 20 #include "base/memory/scoped_ptr.h" |
| 21 #include "base/memory/weak_ptr.h" | 21 #include "base/memory/weak_ptr.h" |
| 22 #include "base/message_loop.h" | 22 #include "base/message_loop.h" |
| 23 #include "base/path_service.h" | 23 #include "base/path_service.h" |
| 24 #include "base/run_loop.h" | |
| 24 #include "base/stl_util.h" | 25 #include "base/stl_util.h" |
| 25 #include "base/string16.h" | 26 #include "base/string16.h" |
| 26 #include "base/string_util.h" | 27 #include "base/string_util.h" |
| 27 #include "base/strings/string_number_conversions.h" | 28 #include "base/strings/string_number_conversions.h" |
| 28 #include "base/utf_string_conversions.h" | 29 #include "base/utf_string_conversions.h" |
| 29 #include "base/version.h" | 30 #include "base/version.h" |
| 30 #include "chrome/browser/browser_process.h" | 31 #include "chrome/browser/browser_process.h" |
| 31 #include "chrome/browser/extensions/app_sync_data.h" | 32 #include "chrome/browser/extensions/app_sync_data.h" |
| 32 #include "chrome/browser/extensions/component_loader.h" | 33 #include "chrome/browser/extensions/component_loader.h" |
| 33 #include "chrome/browser/extensions/crx_installer.h" | 34 #include "chrome/browser/extensions/crx_installer.h" |
| (...skipping 17 matching lines...) Expand all Loading... | |
| 51 #include "chrome/browser/extensions/pending_extension_info.h" | 52 #include "chrome/browser/extensions/pending_extension_info.h" |
| 52 #include "chrome/browser/extensions/pending_extension_manager.h" | 53 #include "chrome/browser/extensions/pending_extension_manager.h" |
| 53 #include "chrome/browser/extensions/test_extension_system.h" | 54 #include "chrome/browser/extensions/test_extension_system.h" |
| 54 #include "chrome/browser/extensions/test_management_policy.h" | 55 #include "chrome/browser/extensions/test_management_policy.h" |
| 55 #include "chrome/browser/extensions/unpacked_installer.h" | 56 #include "chrome/browser/extensions/unpacked_installer.h" |
| 56 #include "chrome/browser/extensions/updater/extension_updater.h" | 57 #include "chrome/browser/extensions/updater/extension_updater.h" |
| 57 #include "chrome/browser/prefs/browser_prefs.h" | 58 #include "chrome/browser/prefs/browser_prefs.h" |
| 58 #include "chrome/browser/prefs/pref_service_mock_builder.h" | 59 #include "chrome/browser/prefs/pref_service_mock_builder.h" |
| 59 #include "chrome/browser/prefs/pref_service_syncable.h" | 60 #include "chrome/browser/prefs/pref_service_syncable.h" |
| 60 #include "chrome/browser/prefs/scoped_user_pref_update.h" | 61 #include "chrome/browser/prefs/scoped_user_pref_update.h" |
| 62 #include "chrome/browser/profiles/profile_manager.h" | |
| 61 #include "chrome/common/chrome_constants.h" | 63 #include "chrome/common/chrome_constants.h" |
| 62 #include "chrome/common/chrome_notification_types.h" | 64 #include "chrome/common/chrome_notification_types.h" |
| 63 #include "chrome/common/chrome_paths.h" | 65 #include "chrome/common/chrome_paths.h" |
| 64 #include "chrome/common/chrome_switches.h" | 66 #include "chrome/common/chrome_switches.h" |
| 65 #include "chrome/common/extensions/api/i18n/default_locale_handler.h" | 67 #include "chrome/common/extensions/api/i18n/default_locale_handler.h" |
| 66 #include "chrome/common/extensions/api/plugins/plugins_handler.h" | 68 #include "chrome/common/extensions/api/plugins/plugins_handler.h" |
| 67 #include "chrome/common/extensions/background_info.h" | 69 #include "chrome/common/extensions/background_info.h" |
| 68 #include "chrome/common/extensions/extension.h" | 70 #include "chrome/common/extensions/extension.h" |
| 69 #include "chrome/common/extensions/extension_l10n_util.h" | 71 #include "chrome/common/extensions/extension_l10n_util.h" |
| 70 #include "chrome/common/extensions/extension_manifest_constants.h" | 72 #include "chrome/common/extensions/extension_manifest_constants.h" |
| 73 #include "chrome/common/extensions/extension_messages.h" | |
| 71 #include "chrome/common/extensions/manifest_handlers/content_scripts_handler.h" | 74 #include "chrome/common/extensions/manifest_handlers/content_scripts_handler.h" |
| 72 #include "chrome/common/extensions/manifest_handlers/requirements_handler.h" | 75 #include "chrome/common/extensions/manifest_handlers/requirements_handler.h" |
| 73 #include "chrome/common/extensions/manifest_url_handler.h" | 76 #include "chrome/common/extensions/manifest_url_handler.h" |
| 74 #include "chrome/common/extensions/permissions/permission_set.h" | 77 #include "chrome/common/extensions/permissions/permission_set.h" |
| 75 #include "chrome/common/pref_names.h" | 78 #include "chrome/common/pref_names.h" |
| 76 #include "chrome/common/url_constants.h" | 79 #include "chrome/common/url_constants.h" |
| 80 #include "chrome/test/base/testing_browser_process.h" | |
| 77 #include "chrome/test/base/testing_profile.h" | 81 #include "chrome/test/base/testing_profile.h" |
| 78 #include "components/user_prefs/pref_registry_syncable.h" | 82 #include "components/user_prefs/pref_registry_syncable.h" |
| 79 #include "content/public/browser/dom_storage_context.h" | 83 #include "content/public/browser/dom_storage_context.h" |
| 80 #include "content/public/browser/gpu_data_manager.h" | 84 #include "content/public/browser/gpu_data_manager.h" |
| 81 #include "content/public/browser/indexed_db_context.h" | 85 #include "content/public/browser/indexed_db_context.h" |
| 82 #include "content/public/browser/notification_registrar.h" | 86 #include "content/public/browser/notification_registrar.h" |
| 83 #include "content/public/browser/notification_service.h" | 87 #include "content/public/browser/notification_service.h" |
| 84 #include "content/public/browser/plugin_service.h" | 88 #include "content/public/browser/plugin_service.h" |
| 85 #include "content/public/browser/storage_partition.h" | 89 #include "content/public/browser/storage_partition.h" |
| 86 #include "content/public/common/content_constants.h" | 90 #include "content/public/common/content_constants.h" |
| 87 #include "content/public/common/gpu_info.h" | 91 #include "content/public/common/gpu_info.h" |
| 92 #include "content/public/test/mock_render_process_host.h" | |
| 88 #include "content/public/test/test_browser_thread.h" | 93 #include "content/public/test/test_browser_thread.h" |
| 94 #include "content/public/test/test_notification_tracker.h" | |
| 89 #include "extensions/common/constants.h" | 95 #include "extensions/common/constants.h" |
| 90 #include "extensions/common/extension_resource.h" | 96 #include "extensions/common/extension_resource.h" |
| 91 #include "extensions/common/url_pattern.h" | 97 #include "extensions/common/url_pattern.h" |
| 92 #include "googleurl/src/gurl.h" | 98 #include "googleurl/src/gurl.h" |
| 93 #include "grit/browser_resources.h" | 99 #include "grit/browser_resources.h" |
| 94 #include "net/cookies/canonical_cookie.h" | 100 #include "net/cookies/canonical_cookie.h" |
| 95 #include "net/cookies/cookie_monster.h" | 101 #include "net/cookies/cookie_monster.h" |
| 96 #include "net/cookies/cookie_options.h" | 102 #include "net/cookies/cookie_options.h" |
| 97 #include "net/url_request/url_request_context.h" | 103 #include "net/url_request/url_request_context.h" |
| 98 #include "net/url_request/url_request_context_getter.h" | 104 #include "net/url_request/url_request_context_getter.h" |
| 99 #include "sync/api/string_ordinal.h" | 105 #include "sync/api/string_ordinal.h" |
| 100 #include "sync/api/sync_error_factory.h" | 106 #include "sync/api/sync_error_factory.h" |
| 101 #include "sync/api/sync_error_factory_mock.h" | 107 #include "sync/api/sync_error_factory_mock.h" |
| 102 #include "sync/protocol/app_specifics.pb.h" | 108 #include "sync/protocol/app_specifics.pb.h" |
| 103 #include "sync/protocol/extension_specifics.pb.h" | 109 #include "sync/protocol/extension_specifics.pb.h" |
| 104 #include "sync/protocol/sync.pb.h" | 110 #include "sync/protocol/sync.pb.h" |
| 111 #include "testing/gmock/include/gmock/gmock.h" | |
| 105 #include "testing/gtest/include/gtest/gtest.h" | 112 #include "testing/gtest/include/gtest/gtest.h" |
| 106 #include "testing/platform_test.h" | 113 #include "testing/platform_test.h" |
| 107 #include "webkit/database/database_tracker.h" | 114 #include "webkit/database/database_tracker.h" |
| 108 #include "webkit/database/database_util.h" | 115 #include "webkit/database/database_util.h" |
| 109 #include "webkit/plugins/npapi/mock_plugin_list.h" | 116 #include "webkit/plugins/npapi/mock_plugin_list.h" |
| 110 #include "webkit/quota/quota_manager.h" | 117 #include "webkit/quota/quota_manager.h" |
| 111 | 118 |
| 112 #if defined(OS_CHROMEOS) | 119 #if defined(OS_CHROMEOS) |
| 113 #include "chrome/browser/chromeos/extensions/install_limiter.h" | 120 #include "chrome/browser/chromeos/extensions/install_limiter.h" |
| 114 #endif | 121 #endif |
| (...skipping 287 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 402 int ids_found_; | 409 int ids_found_; |
| 403 base::FilePath fake_base_path_; | 410 base::FilePath fake_base_path_; |
| 404 int expected_creation_flags_; | 411 int expected_creation_flags_; |
| 405 scoped_ptr<extensions::ExternalProviderImpl> provider_; | 412 scoped_ptr<extensions::ExternalProviderImpl> provider_; |
| 406 scoped_ptr<DictionaryValue> prefs_; | 413 scoped_ptr<DictionaryValue> prefs_; |
| 407 | 414 |
| 408 DISALLOW_COPY_AND_ASSIGN(MockProviderVisitor); | 415 DISALLOW_COPY_AND_ASSIGN(MockProviderVisitor); |
| 409 }; | 416 }; |
| 410 | 417 |
| 411 // Our message loop may be used in tests which require it to be an IO loop. | 418 // Our message loop may be used in tests which require it to be an IO loop. |
| 412 ExtensionServiceTestBase::ExtensionServiceTestBase() | 419 ExtensionServiceTestBase::ExtensionServiceTestBase( |
| 413 : loop_(MessageLoop::TYPE_IO), | 420 MessageLoop::Type main_loop_type) |
| 421 : loop_(main_loop_type), | |
| 414 service_(NULL), | 422 service_(NULL), |
| 415 management_policy_(NULL), | 423 management_policy_(NULL), |
| 416 expected_extensions_count_(0), | 424 expected_extensions_count_(0), |
| 417 ui_thread_(BrowserThread::UI, &loop_), | 425 ui_thread_(BrowserThread::UI, &loop_), |
| 418 db_thread_(BrowserThread::DB, &loop_), | 426 db_thread_(BrowserThread::DB, &loop_), |
| 419 webkit_thread_(BrowserThread::WEBKIT_DEPRECATED, &loop_), | 427 webkit_thread_(BrowserThread::WEBKIT_DEPRECATED, &loop_), |
| 420 file_thread_(BrowserThread::FILE, &loop_), | 428 file_thread_(BrowserThread::FILE, &loop_), |
| 421 file_user_blocking_thread_(BrowserThread::FILE_USER_BLOCKING, &loop_), | 429 file_user_blocking_thread_(BrowserThread::FILE_USER_BLOCKING, &loop_), |
| 422 io_thread_(BrowserThread::IO, &loop_), | 430 io_thread_(main_loop_type == MessageLoop::TYPE_IO ? |
|
Jeffrey Yasskin
2013/04/10 16:18:57
Ew. What we actually need to do is split the helpe
| |
| 431 new content::TestBrowserThread(BrowserThread::IO, &loop_) : | |
| 432 new content::TestBrowserThread(BrowserThread::IO)), | |
| 423 override_sideload_wipeout_( | 433 override_sideload_wipeout_( |
| 424 FeatureSwitch::sideload_wipeout(), false) { | 434 FeatureSwitch::sideload_wipeout(), false) { |
| 435 if (main_loop_type != MessageLoop::TYPE_IO) | |
| 436 io_thread_->StartIOThread(); | |
| 425 base::FilePath test_data_dir; | 437 base::FilePath test_data_dir; |
| 426 if (!PathService::Get(chrome::DIR_TEST_DATA, &test_data_dir)) { | 438 if (!PathService::Get(chrome::DIR_TEST_DATA, &test_data_dir)) { |
| 427 ADD_FAILURE(); | 439 ADD_FAILURE(); |
| 428 return; | 440 return; |
| 429 } | 441 } |
| 430 data_dir_ = test_data_dir.AppendASCII("extensions"); | 442 data_dir_ = test_data_dir.AppendASCII("extensions"); |
| 431 } | 443 } |
| 432 | 444 |
| 433 ExtensionServiceTestBase::~ExtensionServiceTestBase() { | 445 ExtensionServiceTestBase::~ExtensionServiceTestBase() { |
| 434 // Drop our reference to ExtensionService and TestingProfile, so that they | 446 // Drop our reference to ExtensionService and TestingProfile, so that they |
| 435 // can be destroyed while BrowserThreads and MessageLoop are still around | 447 // can be destroyed while BrowserThreads and MessageLoop are still around |
| 436 // (they are used in the destruction process). | 448 // (they are used in the destruction process). |
| 437 service_ = NULL; | 449 service_ = NULL; |
| 438 MessageLoop::current()->RunUntilIdle(); | 450 MessageLoop::current()->RunUntilIdle(); |
| 439 profile_.reset(NULL); | 451 profile_.reset(NULL); |
| 440 MessageLoop::current()->RunUntilIdle(); | 452 MessageLoop::current()->RunUntilIdle(); |
| 453 | |
| 454 TestingBrowserProcess::GetGlobal()->SetProfileManager(NULL); | |
| 441 } | 455 } |
| 442 | 456 |
| 443 void ExtensionServiceTestBase::InitializeExtensionService( | 457 void ExtensionServiceTestBase::InitializeExtensionService( |
| 444 const base::FilePath& profile_path, | 458 const base::FilePath& profile_path, |
| 445 const base::FilePath& pref_file, | 459 const base::FilePath& pref_file, |
| 446 const base::FilePath& extensions_install_dir, | 460 const base::FilePath& extensions_install_dir, |
| 447 bool autoupdate_enabled) { | 461 bool autoupdate_enabled) { |
| 448 TestingProfile::Builder profile_builder; | 462 TestingProfile::Builder profile_builder; |
| 449 // Create a PrefService that only contains user defined preference values. | 463 // Create a PrefService that only contains user defined preference values. |
| 450 PrefServiceMockBuilder builder; | 464 PrefServiceMockBuilder builder; |
| (...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 500 file_util::CopyDirectory(source_install_dir, extensions_install_dir_, true); | 514 file_util::CopyDirectory(source_install_dir, extensions_install_dir_, true); |
| 501 | 515 |
| 502 InitializeExtensionService(path, temp_prefs, extensions_install_dir_, false); | 516 InitializeExtensionService(path, temp_prefs, extensions_install_dir_, false); |
| 503 } | 517 } |
| 504 | 518 |
| 505 void ExtensionServiceTestBase::InitializeEmptyExtensionService() { | 519 void ExtensionServiceTestBase::InitializeEmptyExtensionService() { |
| 506 InitializeExtensionServiceHelper(false); | 520 InitializeExtensionServiceHelper(false); |
| 507 } | 521 } |
| 508 | 522 |
| 509 void ExtensionServiceTestBase::InitializeExtensionProcessManager() { | 523 void ExtensionServiceTestBase::InitializeExtensionProcessManager() { |
| 524 // Needed in order to look up RenderProcessHosts. | |
| 525 TestingBrowserProcess::GetGlobal()->SetProfileManager( | |
| 526 new ProfileManagerWithoutInit(temp_dir_.path())); | |
| 527 | |
| 510 static_cast<extensions::TestExtensionSystem*>( | 528 static_cast<extensions::TestExtensionSystem*>( |
| 511 ExtensionSystem::Get(profile_.get()))-> | 529 ExtensionSystem::Get(profile_.get()))-> |
| 512 CreateExtensionProcessManager(); | 530 CreateExtensionProcessManager(); |
| 513 } | 531 } |
| 514 | 532 |
| 515 void ExtensionServiceTestBase::InitializeExtensionServiceWithUpdater() { | 533 void ExtensionServiceTestBase::InitializeExtensionServiceWithUpdater() { |
| 516 InitializeExtensionServiceHelper(true); | 534 InitializeExtensionServiceHelper(true); |
| 517 service_->updater()->Start(); | 535 service_->updater()->Start(); |
| 518 } | 536 } |
| 519 | 537 |
| (...skipping 29 matching lines...) Expand all Loading... | |
| 549 void ExtensionServiceTestBase::SetUp() { | 567 void ExtensionServiceTestBase::SetUp() { |
| 550 ExtensionTest::SetUp(); | 568 ExtensionTest::SetUp(); |
| 551 ExtensionErrorReporter::GetInstance()->ClearErrors(); | 569 ExtensionErrorReporter::GetInstance()->ClearErrors(); |
| 552 (new extensions::BackgroundManifestHandler)->Register(); | 570 (new extensions::BackgroundManifestHandler)->Register(); |
| 553 (new extensions::ContentScriptsHandler)->Register(); | 571 (new extensions::ContentScriptsHandler)->Register(); |
| 554 (new extensions::DefaultLocaleHandler)->Register(); | 572 (new extensions::DefaultLocaleHandler)->Register(); |
| 555 (new extensions::PluginsHandler)->Register(); | 573 (new extensions::PluginsHandler)->Register(); |
| 556 (new extensions::RequirementsHandler)->Register(); | 574 (new extensions::RequirementsHandler)->Register(); |
| 557 } | 575 } |
| 558 | 576 |
| 577 template<typename Result> | |
| 578 static Result PostTaskAndWaitForResult( | |
| 579 content::BrowserThread::ID thread, | |
| 580 const tracked_objects::Location& from_here, | |
| 581 const base::Callback<Result(void)>& task) { | |
| 582 struct ResultSaver { | |
| 583 static void UpdateResult(base::RunLoop* loop, | |
| 584 Result* saved, | |
| 585 Result from_task) { | |
| 586 using std::swap; | |
| 587 swap(*saved, from_task); | |
| 588 loop->Quit(); | |
| 589 } | |
| 590 }; | |
| 591 | |
| 592 Result result; | |
| 593 base::RunLoop loop; | |
| 594 content::BrowserThread::PostTaskAndReplyWithResult( | |
| 595 thread, from_here, task, | |
| 596 base::Bind(&ResultSaver::UpdateResult, | |
| 597 base::Unretained(&loop), | |
| 598 base::Unretained(&result))); | |
| 599 loop.Run(); | |
| 600 return result; | |
| 601 } | |
| 602 | |
| 559 class ExtensionServiceTest | 603 class ExtensionServiceTest |
| 560 : public ExtensionServiceTestBase, public content::NotificationObserver { | 604 : public ExtensionServiceTestBase, public content::NotificationObserver { |
| 561 public: | 605 public: |
| 562 ExtensionServiceTest() | 606 ExtensionServiceTest() |
| 563 : installed_(NULL), | 607 : installed_(NULL), |
| 564 override_external_install_prompt_( | 608 override_external_install_prompt_( |
| 565 FeatureSwitch::prompt_for_external_extensions(), false) { | 609 FeatureSwitch::prompt_for_external_extensions(), false) { |
| 566 registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_LOADED, | 610 registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_LOADED, |
| 567 content::NotificationService::AllSources()); | 611 content::NotificationService::AllSources()); |
| 568 registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_UNLOADED, | 612 registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_UNLOADED, |
| (...skipping 3031 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 3600 // EnableExtension() call above inserted into it and | 3644 // EnableExtension() call above inserted into it and |
| 3601 // UnloadAllExtensions() doesn't send out notifications. | 3645 // UnloadAllExtensions() doesn't send out notifications. |
| 3602 loaded_.clear(); | 3646 loaded_.clear(); |
| 3603 service_->ReloadExtensions(); | 3647 service_->ReloadExtensions(); |
| 3604 | 3648 |
| 3605 // Extension counts shouldn't change. | 3649 // Extension counts shouldn't change. |
| 3606 EXPECT_EQ(1u, service_->extensions()->size()); | 3650 EXPECT_EQ(1u, service_->extensions()->size()); |
| 3607 EXPECT_EQ(0u, service_->disabled_extensions()->size()); | 3651 EXPECT_EQ(0u, service_->disabled_extensions()->size()); |
| 3608 } | 3652 } |
| 3609 | 3653 |
| 3654 namespace { | |
| 3655 std::vector<uint32> ExtensionMessageTypes(const IPC::TestSink& sink) { | |
| 3656 std::vector<uint32> message_types; | |
| 3657 for (size_t i = 0; i < sink.message_count(); ++i) { | |
| 3658 uint32 type = sink.GetMessageAt(i)->type(); | |
| 3659 if (IPC_MESSAGE_ID_CLASS(type) == ExtensionMsgStart) | |
| 3660 message_types.push_back(type); | |
| 3661 } | |
| 3662 return message_types; | |
| 3663 } | |
| 3664 | |
| 3665 struct ProcessObserver | |
| 3666 : public content::MockRenderProcessHostFactory::Observer { | |
| 3667 explicit ProcessObserver(content::MockRenderProcessHostFactory* factory) | |
| 3668 : Observer(factory) {} | |
| 3669 | |
| 3670 ~ProcessObserver() { | |
| 3671 for (size_t i = 0; i < hosts.size(); ++i) { | |
| 3672 if (destroyed_processes.count(process_ids[i]) == 0) | |
| 3673 hosts[i]->sink().RemoveFilter(process_messages[i]); | |
| 3674 delete process_messages[i]; | |
| 3675 } | |
| 3676 } | |
| 3677 | |
| 3678 virtual void OnRenderProcessHostCreated( | |
| 3679 content::MockRenderProcessHost* host) { | |
| 3680 IPC::TestSink* sink = new IPC::TestSink; | |
| 3681 hosts.push_back(host); | |
| 3682 process_ids.push_back(host->GetID()); | |
| 3683 process_messages.push_back(sink); | |
| 3684 host->sink().AddFilter(sink); | |
| 3685 } | |
| 3686 virtual void OnRenderProcessHostDestroyed( | |
| 3687 content::MockRenderProcessHost* host) { | |
| 3688 destroyed_processes.insert(host->GetID()); | |
| 3689 } | |
| 3690 | |
| 3691 std::vector<content::MockRenderProcessHost*> hosts; | |
| 3692 std::vector<int> process_ids; | |
| 3693 std::vector<IPC::TestSink*> process_messages; | |
| 3694 std::set<int> destroyed_processes; | |
| 3695 }; | |
| 3696 } // namespace | |
| 3697 | |
| 3610 // Tests reloading an extension. | 3698 // Tests reloading an extension. |
| 3611 TEST_F(ExtensionServiceTest, ReloadExtension) { | 3699 TEST_F(ExtensionServiceTest, ReloadExtension) { |
| 3700 ProcessObserver observer(rvh_enabler_.rph_factory()); | |
| 3701 | |
| 3702 content::TestNotificationTracker notifications; | |
| 3703 notifications.ListenForAll(chrome::NOTIFICATION_EXTENSIONS_READY); | |
| 3704 notifications.ListenForAll(chrome::NOTIFICATION_EXTENSION_HOST_DESTROYED); | |
| 3705 notifications.ListenForAll(chrome::NOTIFICATION_EXTENSION_LOADED); | |
| 3706 notifications.ListenForAll(chrome::NOTIFICATION_EXTENSION_UNLOADED); | |
| 3707 notifications.ListenForAll(content::NOTIFICATION_RENDERER_PROCESS_CLOSING); | |
| 3708 notifications.ListenForAll(content::NOTIFICATION_RENDERER_PROCESS_CREATED); | |
| 3709 notifications.ListenForAll(content::NOTIFICATION_RENDERER_PROCESS_TERMINATED); | |
| 3710 notifications.ListenForAll( | |
| 3711 content::NOTIFICATION_RENDER_VIEW_HOST_WILL_CLOSE_RENDER_VIEW); | |
| 3712 | |
| 3612 InitializeEmptyExtensionService(); | 3713 InitializeEmptyExtensionService(); |
| 3613 InitializeExtensionProcessManager(); | 3714 InitializeExtensionProcessManager(); |
| 3715 service_->Init(); | |
| 3716 EXPECT_THAT(notifications.GetTypesAndReset(), | |
| 3717 testing::ElementsAre(chrome::NOTIFICATION_EXTENSIONS_READY)); | |
| 3614 | 3718 |
| 3615 // Simple extension that should install without error. | 3719 // Simple extension that should install without error. |
| 3616 const char* extension_id = "behllobkkfkfnphdnhnkndlbkcpglgmj"; | 3720 const char* extension_id = "behllobkkfkfnphdnhnkndlbkcpglgmj"; |
| 3617 base::FilePath ext = data_dir_ | 3721 base::FilePath ext = data_dir_ |
| 3618 .AppendASCII("good") | 3722 .AppendASCII("good") |
| 3619 .AppendASCII("Extensions") | 3723 .AppendASCII("Extensions") |
| 3620 .AppendASCII(extension_id) | 3724 .AppendASCII(extension_id) |
| 3621 .AppendASCII("1.0.0.0"); | 3725 .AppendASCII("1.0.0.0"); |
| 3622 extensions::UnpackedInstaller::Create(service_)->Load(ext); | 3726 extensions::UnpackedInstaller::Create(service_)->Load(ext); |
| 3623 loop_.RunUntilIdle(); | 3727 loop_.RunUntilIdle(); |
| 3624 | 3728 |
| 3729 EXPECT_THAT(notifications.GetTypesAndReset(), | |
| 3730 testing::ElementsAre(chrome::NOTIFICATION_EXTENSION_LOADED)); | |
| 3731 ASSERT_EQ(1u, observer.process_messages.size()); | |
| 3732 EXPECT_THAT(ExtensionMessageTypes(*observer.process_messages[0]), | |
| 3733 testing::ElementsAre(ExtensionMsg_Loaded::ID, | |
| 3734 ExtensionMsg_ActivateExtension::ID, | |
| 3735 ExtensionMsg_Loaded::ID, | |
| 3736 ExtensionMsg_ActivateExtension::ID)); | |
| 3737 observer.process_messages[0]->ClearMessages(); | |
| 3738 | |
| 3625 EXPECT_EQ(1u, service_->extensions()->size()); | 3739 EXPECT_EQ(1u, service_->extensions()->size()); |
| 3626 EXPECT_EQ(0u, service_->disabled_extensions()->size()); | 3740 EXPECT_EQ(0u, service_->disabled_extensions()->size()); |
| 3627 | 3741 |
| 3628 service_->ReloadExtension(extension_id); | 3742 service_->ReloadExtension(extension_id); |
| 3629 | 3743 |
| 3744 EXPECT_THAT(notifications.GetTypesAndReset(), | |
| 3745 testing::ElementsAre( | |
| 3746 chrome::NOTIFICATION_EXTENSION_UNLOADED, | |
| 3747 content::NOTIFICATION_RENDERER_PROCESS_CLOSING, | |
| 3748 chrome::NOTIFICATION_EXTENSION_HOST_DESTROYED, | |
| 3749 content::NOTIFICATION_RENDERER_PROCESS_TERMINATED)); | |
| 3750 | |
| 3751 ASSERT_EQ(1u, observer.process_messages.size()); | |
| 3752 EXPECT_THAT(ExtensionMessageTypes(*observer.process_messages[0]), | |
| 3753 testing::ElementsAre()); | |
| 3754 observer.process_messages[0]->ClearMessages(); | |
| 3755 | |
| 3630 // Extension should be disabled now, waiting to be reloaded. | 3756 // Extension should be disabled now, waiting to be reloaded. |
| 3631 EXPECT_EQ(0u, service_->extensions()->size()); | 3757 EXPECT_EQ(0u, service_->extensions()->size()); |
| 3632 EXPECT_EQ(1u, service_->disabled_extensions()->size()); | 3758 EXPECT_EQ(1u, service_->disabled_extensions()->size()); |
| 3633 EXPECT_EQ(Extension::DISABLE_RELOAD, | 3759 EXPECT_EQ(Extension::DISABLE_RELOAD, |
| 3634 service_->extension_prefs()->GetDisableReasons(extension_id)); | 3760 service_->extension_prefs()->GetDisableReasons(extension_id)); |
| 3635 | 3761 |
| 3636 // Reloading again should not crash. | 3762 // Reloading again before iterating the MessageLoop should not crash and |
| 3763 // shouldn't cause an extra reload. | |
| 3637 service_->ReloadExtension(extension_id); | 3764 service_->ReloadExtension(extension_id); |
| 3765 EXPECT_THAT(notifications.GetTypesAndReset(), | |
| 3766 testing::ElementsAre()); | |
| 3767 ASSERT_EQ(1u, observer.process_messages.size()); | |
| 3768 EXPECT_THAT(ExtensionMessageTypes(*observer.process_messages[0]), | |
| 3769 testing::ElementsAre()); | |
| 3770 observer.process_messages[0]->ClearMessages(); | |
| 3638 | 3771 |
| 3639 // Finish reloading | 3772 // Finish reloading |
| 3640 loop_.RunUntilIdle(); | 3773 loop_.RunUntilIdle(); |
| 3641 | 3774 |
| 3775 EXPECT_THAT(notifications.GetTypesAndReset(), | |
| 3776 testing::ElementsAre( | |
| 3777 chrome::NOTIFICATION_EXTENSION_LOADED, | |
| 3778 chrome::NOTIFICATION_EXTENSION_UNLOADED, | |
| 3779 content::NOTIFICATION_RENDERER_PROCESS_CLOSING, | |
| 3780 chrome::NOTIFICATION_EXTENSION_HOST_DESTROYED, | |
| 3781 content::NOTIFICATION_RENDERER_PROCESS_TERMINATED, | |
| 3782 chrome::NOTIFICATION_EXTENSION_LOADED)); | |
| 3783 | |
| 3784 ASSERT_EQ(3u, observer.process_messages.size()); | |
| 3785 EXPECT_THAT(observer.destroyed_processes, | |
| 3786 testing::ElementsAre(observer.process_ids[0], | |
| 3787 observer.process_ids[1])); | |
| 3788 EXPECT_THAT(ExtensionMessageTypes(*observer.process_messages[0]), | |
| 3789 testing::ElementsAre()); | |
| 3790 observer.process_messages[0]->ClearMessages(); | |
| 3791 EXPECT_THAT(ExtensionMessageTypes(*observer.process_messages[1]), | |
| 3792 testing::ElementsAre(ExtensionMsg_Loaded::ID, | |
| 3793 ExtensionMsg_ActivateExtension::ID, | |
| 3794 ExtensionMsg_Loaded::ID, | |
| 3795 ExtensionMsg_ActivateExtension::ID)); | |
| 3796 observer.process_messages[1]->ClearMessages(); | |
| 3797 EXPECT_THAT(ExtensionMessageTypes(*observer.process_messages[2]), | |
| 3798 testing::ElementsAre(ExtensionMsg_Loaded::ID, | |
| 3799 ExtensionMsg_ActivateExtension::ID, | |
| 3800 ExtensionMsg_Loaded::ID, | |
| 3801 ExtensionMsg_ActivateExtension::ID)); | |
| 3802 observer.process_messages[2]->ClearMessages(); | |
| 3803 | |
| 3642 // Extension should be enabled again. | 3804 // Extension should be enabled again. |
| 3643 EXPECT_EQ(1u, service_->extensions()->size()); | 3805 EXPECT_EQ(1u, service_->extensions()->size()); |
| 3644 EXPECT_EQ(0u, service_->disabled_extensions()->size()); | 3806 EXPECT_EQ(0u, service_->disabled_extensions()->size()); |
| 3645 } | 3807 } |
| 3646 | 3808 |
| 3647 TEST_F(ExtensionServiceTest, UninstallExtension) { | 3809 TEST_F(ExtensionServiceTest, UninstallExtension) { |
| 3648 InitializeEmptyExtensionService(); | 3810 InitializeEmptyExtensionService(); |
| 3649 InstallCRX(data_dir_.AppendASCII("good.crx"), INSTALL_NEW); | 3811 InstallCRX(data_dir_.AppendASCII("good.crx"), INSTALL_NEW); |
| 3650 EXPECT_EQ(1u, service_->extensions()->size()); | 3812 EXPECT_EQ(1u, service_->extensions()->size()); |
| 3651 UninstallExtension(good_crx, false); | 3813 UninstallExtension(good_crx, false); |
| (...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 3776 .AppendASCII("v2_bad_requirements"); | 3938 .AppendASCII("v2_bad_requirements"); |
| 3777 extensions::UnpackedInstaller::Create(service_)->Load(path); | 3939 extensions::UnpackedInstaller::Create(service_)->Load(path); |
| 3778 loop_.RunUntilIdle(); | 3940 loop_.RunUntilIdle(); |
| 3779 EXPECT_EQ(1u, GetErrors().size()); | 3941 EXPECT_EQ(1u, GetErrors().size()); |
| 3780 EXPECT_EQ(0u, service_->extensions()->size()); | 3942 EXPECT_EQ(0u, service_->extensions()->size()); |
| 3781 } | 3943 } |
| 3782 | 3944 |
| 3783 class ExtensionCookieCallback { | 3945 class ExtensionCookieCallback { |
| 3784 public: | 3946 public: |
| 3785 ExtensionCookieCallback() | 3947 ExtensionCookieCallback() |
| 3786 : result_(false), | 3948 : result_(false), |
| 3787 weak_factory_(MessageLoop::current()) {} | 3949 weak_factory_(MessageLoop::current()) {} |
| 3788 | 3950 |
| 3789 void SetCookieCallback(bool result) { | 3951 void SetCookieCallback(bool result) { |
| 3790 MessageLoop::current()->PostTask( | 3952 MessageLoop::current()->PostTask( |
| 3791 FROM_HERE, base::Bind(&MessageLoop::Quit, weak_factory_.GetWeakPtr())); | 3953 FROM_HERE, base::Bind(&MessageLoop::Quit, weak_factory_.GetWeakPtr())); |
| 3792 result_ = result; | 3954 result_ = result; |
| 3793 } | 3955 } |
| 3794 | 3956 |
| 3795 void GetAllCookiesCallback(const net::CookieList& list) { | 3957 void GetAllCookiesCallback(const net::CookieList& list) { |
| 3796 MessageLoop::current()->PostTask( | 3958 MessageLoop::current()->PostTask( |
| 3797 FROM_HERE, base::Bind(&MessageLoop::Quit, weak_factory_.GetWeakPtr())); | 3959 FROM_HERE, base::Bind(&MessageLoop::Quit, weak_factory_.GetWeakPtr())); |
| 3798 list_ = list; | 3960 list_ = list; |
| 3799 } | 3961 } |
| 3962 | |
| 3800 net::CookieList list_; | 3963 net::CookieList list_; |
| 3801 bool result_; | 3964 bool result_; |
| 3802 base::WeakPtrFactory<MessageLoop> weak_factory_; | 3965 base::WeakPtrFactory<MessageLoop> weak_factory_; |
| 3803 }; | 3966 }; |
| 3804 | 3967 |
| 3968 // Must run on IO thread to set up ThreadCheckers correctly. | |
| 3969 static net::CookieMonster* GetCookieMonsterFromIOThread( | |
| 3970 net::URLRequestContextGetter* getter) { | |
| 3971 return getter->GetURLRequestContext()->cookie_store()->GetCookieMonster(); | |
| 3972 } | |
| 3973 | |
| 3805 // Verifies extension state is removed upon uninstall. | 3974 // Verifies extension state is removed upon uninstall. |
| 3806 TEST_F(ExtensionServiceTest, ClearExtensionData) { | 3975 TEST_F(ExtensionServiceTest, ClearExtensionData) { |
| 3807 InitializeEmptyExtensionService(); | 3976 InitializeEmptyExtensionService(); |
| 3808 ExtensionCookieCallback callback; | 3977 ExtensionCookieCallback callback; |
| 3809 | 3978 |
| 3810 // Load a test extension. | 3979 // Load a test extension. |
| 3811 base::FilePath path = data_dir_; | 3980 base::FilePath path = data_dir_; |
| 3812 path = path.AppendASCII("good.crx"); | 3981 path = path.AppendASCII("good.crx"); |
| 3813 const Extension* extension = InstallCRX(path, INSTALL_NEW); | 3982 const Extension* extension = InstallCRX(path, INSTALL_NEW); |
| 3814 ASSERT_TRUE(extension); | 3983 ASSERT_TRUE(extension); |
| 3815 GURL ext_url(extension->url()); | 3984 GURL ext_url(extension->url()); |
| 3816 string16 origin_id = | 3985 string16 origin_id = |
| 3817 webkit_database::DatabaseUtil::GetOriginIdentifier(ext_url); | 3986 webkit_database::DatabaseUtil::GetOriginIdentifier(ext_url); |
| 3818 | 3987 |
| 3819 // Set a cookie for the extension. | 3988 // Set a cookie for the extension. |
| 3820 net::CookieMonster* cookie_monster = | 3989 net::CookieMonster* cookie_monster = PostTaskAndWaitForResult( |
| 3821 profile_->GetRequestContextForExtensions()->GetURLRequestContext()-> | 3990 BrowserThread::IO, FROM_HERE, |
| 3822 cookie_store()->GetCookieMonster(); | 3991 base::Bind(&GetCookieMonsterFromIOThread, |
| 3992 make_scoped_refptr( | |
| 3993 profile_->GetRequestContextForExtensions()))); | |
| 3823 ASSERT_TRUE(cookie_monster); | 3994 ASSERT_TRUE(cookie_monster); |
| 3995 | |
| 3824 net::CookieOptions options; | 3996 net::CookieOptions options; |
| 3825 cookie_monster->SetCookieWithOptionsAsync( | 3997 cookie_monster->SetCookieWithOptionsAsync( |
| 3826 ext_url, "dummy=value", options, | 3998 ext_url, "dummy=value", options, |
| 3827 base::Bind(&ExtensionCookieCallback::SetCookieCallback, | 3999 base::Bind(&ExtensionCookieCallback::SetCookieCallback, |
| 3828 base::Unretained(&callback))); | 4000 base::Unretained(&callback))); |
| 3829 loop_.RunUntilIdle(); | 4001 MessageLoop::current()->RunUntilIdle(); |
| 3830 EXPECT_TRUE(callback.result_); | 4002 EXPECT_TRUE(callback.result_); |
| 3831 | 4003 |
| 3832 cookie_monster->GetAllCookiesForURLAsync( | 4004 cookie_monster->GetAllCookiesForURLAsync( |
| 3833 ext_url, | 4005 ext_url, |
| 3834 base::Bind(&ExtensionCookieCallback::GetAllCookiesCallback, | 4006 base::Bind(&ExtensionCookieCallback::GetAllCookiesCallback, |
| 3835 base::Unretained(&callback))); | 4007 base::Unretained(&callback))); |
| 3836 loop_.RunUntilIdle(); | 4008 MessageLoop::current()->RunUntilIdle(); |
| 3837 EXPECT_EQ(1U, callback.list_.size()); | 4009 EXPECT_EQ(1U, callback.list_.size()); |
| 3838 | 4010 |
| 3839 // Open a database. | 4011 // Open a database. |
| 3840 webkit_database::DatabaseTracker* db_tracker = | 4012 webkit_database::DatabaseTracker* db_tracker = |
| 3841 BrowserContext::GetDefaultStoragePartition(profile_.get())-> | 4013 BrowserContext::GetDefaultStoragePartition(profile_.get())-> |
| 3842 GetDatabaseTracker(); | 4014 GetDatabaseTracker(); |
| 3843 string16 db_name = UTF8ToUTF16("db"); | 4015 string16 db_name = UTF8ToUTF16("db"); |
| 3844 string16 description = UTF8ToUTF16("db_description"); | 4016 string16 description = UTF8ToUTF16("db_description"); |
| 3845 int64 size; | 4017 int64 size; |
| 3846 db_tracker->DatabaseOpened(origin_id, db_name, description, 1, &size); | 4018 db_tracker->DatabaseOpened(origin_id, db_name, description, 1, &size); |
| (...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 3924 EXPECT_TRUE(extension->HasAPIPermission( | 4096 EXPECT_TRUE(extension->HasAPIPermission( |
| 3925 APIPermission::kUnlimitedStorage)); | 4097 APIPermission::kUnlimitedStorage)); |
| 3926 EXPECT_TRUE(extension->web_extent().MatchesURL( | 4098 EXPECT_TRUE(extension->web_extent().MatchesURL( |
| 3927 extension->GetFullLaunchURL())); | 4099 extension->GetFullLaunchURL())); |
| 3928 const GURL origin2(extension->GetFullLaunchURL().GetOrigin()); | 4100 const GURL origin2(extension->GetFullLaunchURL().GetOrigin()); |
| 3929 EXPECT_EQ(origin1, origin2); | 4101 EXPECT_EQ(origin1, origin2); |
| 3930 EXPECT_TRUE(profile_->GetExtensionSpecialStoragePolicy()-> | 4102 EXPECT_TRUE(profile_->GetExtensionSpecialStoragePolicy()-> |
| 3931 IsStorageUnlimited(origin2)); | 4103 IsStorageUnlimited(origin2)); |
| 3932 | 4104 |
| 3933 // Set a cookie for the extension. | 4105 // Set a cookie for the extension. |
| 3934 net::CookieMonster* cookie_monster = | 4106 net::CookieMonster* cookie_monster = PostTaskAndWaitForResult( |
| 3935 profile_->GetRequestContext()->GetURLRequestContext()-> | 4107 BrowserThread::IO, FROM_HERE, |
| 3936 cookie_store()->GetCookieMonster(); | 4108 base::Bind(&GetCookieMonsterFromIOThread, |
| 4109 make_scoped_refptr(profile_->GetRequestContext()))); | |
| 3937 ASSERT_TRUE(cookie_monster); | 4110 ASSERT_TRUE(cookie_monster); |
| 3938 net::CookieOptions options; | 4111 net::CookieOptions options; |
| 3939 cookie_monster->SetCookieWithOptionsAsync( | 4112 cookie_monster->SetCookieWithOptionsAsync( |
| 3940 origin1, "dummy=value", options, | 4113 origin1, "dummy=value", options, |
| 3941 base::Bind(&ExtensionCookieCallback::SetCookieCallback, | 4114 base::Bind(&ExtensionCookieCallback::SetCookieCallback, |
| 3942 base::Unretained(&callback))); | 4115 base::Unretained(&callback))); |
| 3943 loop_.RunUntilIdle(); | 4116 loop_.RunUntilIdle(); |
| 3944 EXPECT_TRUE(callback.result_); | 4117 EXPECT_TRUE(callback.result_); |
| 3945 | 4118 |
| 3946 cookie_monster->GetAllCookiesForURLAsync( | 4119 cookie_monster->GetAllCookiesForURLAsync( |
| (...skipping 1954 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 5901 EXPECT_FALSE(extensions::HasExternalInstallError(service_)); | 6074 EXPECT_FALSE(extensions::HasExternalInstallError(service_)); |
| 5902 EXPECT_FALSE(service_->IsExtensionEnabled(good_crx)); | 6075 EXPECT_FALSE(service_->IsExtensionEnabled(good_crx)); |
| 5903 EXPECT_TRUE(service_->IsExtensionEnabled(page_action)); | 6076 EXPECT_TRUE(service_->IsExtensionEnabled(page_action)); |
| 5904 | 6077 |
| 5905 ExtensionPrefs* prefs = service_->extension_prefs(); | 6078 ExtensionPrefs* prefs = service_->extension_prefs(); |
| 5906 EXPECT_NE(0, prefs->GetDisableReasons(good_crx) & | 6079 EXPECT_NE(0, prefs->GetDisableReasons(good_crx) & |
| 5907 Extension::DISABLE_SIDELOAD_WIPEOUT); | 6080 Extension::DISABLE_SIDELOAD_WIPEOUT); |
| 5908 EXPECT_EQ(0, prefs->GetDisableReasons(page_action) & | 6081 EXPECT_EQ(0, prefs->GetDisableReasons(page_action) & |
| 5909 Extension::DISABLE_SIDELOAD_WIPEOUT); | 6082 Extension::DISABLE_SIDELOAD_WIPEOUT); |
| 5910 } | 6083 } |
| OLD | NEW |