Test extension reloading behavior.

content/browser/site_instance_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/site_instance_impl.h"
 
 #include "base/command_line.h"
 #include "content/browser/browsing_instance.h"
 #include "content/browser/child_process_security_policy_impl.h"
 #include "content/browser/renderer_host/render_process_host_impl.h"
@@ skipping 173 matching lines @@
 
 bool SiteInstanceImpl::HasSite() const {
   return has_site_;
 }
 
 bool SiteInstanceImpl::HasRelatedSiteInstance(const GURL& url) {
   return browsing_instance_->HasSiteInstance(url);
 }
 
 SiteInstance* SiteInstanceImpl::GetRelatedSiteInstance(const GURL& url) {
-  return browsing_instance_->GetSiteInstanceForURL(url);
+  SiteInstance* result = browsing_instance_->GetSiteInstanceForURL(url);
+  if (render_process_host_factory_)
+    result->SetRenderProcessHostFactoryForTesting(render_process_host_factory_);

[Jeffrey Yasskin, 2013/04/08 16:30:48]

I got a "calling functions intended only for testing" warning from this, but I
think that's ok in this case?

[jam, 2013/04/08 16:54:53]

ah, since there's a call path in a non-test file, you can't use it. ignore my
message then

[Paweł Hajdan Jr., 2013/04/08 20:03:51]

By the way, calling Set, a mutating method in a method called Get is a
_terrible_ idea, testing or not.

[Jeffrey Yasskin, 2013/04/08 22:09:38]

What? The Set() is on the newly-constructed result object, not *this.

[Jeffrey Yasskin, 2013/04/08 22:09:38]

Well, I could put back the changes to browsing_instance.h and then modify
result->render_process_host_factory_ directly. Which do you prefer?

[Paweł Hajdan Jr., 2013/04/08 22:17:38]

Oops, this makes more sense. Please ignore my earlier comment.

[Jeffrey Yasskin, 2013/04/08 22:38:02]

Done, although I can switch to directly modifying the member if you prefer that
option.

+  return result;
 }
 
 bool SiteInstanceImpl::IsRelatedSiteInstance(const SiteInstance* instance) {
   return browsing_instance_ ==
       static_cast<const SiteInstanceImpl*>(instance)->browsing_instance_;
 }
 
 bool SiteInstanceImpl::HasWrongProcessForURL(const GURL& url) {
   // Having no process isn't a problem, since we'll assign it correctly.
   // Note that HasProcess() may return true if process_ is null, in
@@ skipping 12 matching lines @@
   // process is not (or vice versa), make sure we notice and fix it.
   GURL site_url = GetSiteForURL(browsing_instance_->browser_context(), url);
   return !RenderProcessHostImpl::IsSuitableHost(
       GetProcess(), browsing_instance_->browser_context(), site_url);
 }
 
 BrowserContext* SiteInstanceImpl::GetBrowserContext() const {
   return browsing_instance_->browser_context();
 }
 
+void SiteInstanceImpl::SetRenderProcessHostFactoryForTesting(
+    const RenderProcessHostFactory* rph_factory) {
+  render_process_host_factory_ = rph_factory;
+}
+
 /*static*/
 SiteInstance* SiteInstance::Create(BrowserContext* browser_context) {
   return new SiteInstanceImpl(new BrowsingInstance(browser_context));
 }
 
 /*static*/
 SiteInstance* SiteInstance::CreateForURL(BrowserContext* browser_context,
                                          const GURL& url) {
   // This BrowsingInstance may be deleted if it returns an existing
   // SiteInstance.
@@ skipping 93 matching lines @@
   const CommandLine& command_line = *CommandLine::ForCurrentProcess();
   if (command_line.HasSwitch(switches::kEnableStrictSiteIsolation) ||
       command_line.HasSwitch(switches::kSitePerProcess)) {
     ChildProcessSecurityPolicyImpl* policy =
         ChildProcessSecurityPolicyImpl::GetInstance();
     policy->LockToOrigin(process_->GetID(), site_);
   }
 }
 
 }  // namespace content