Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 1353243002: Nicer error for JS() form with mismatched arguments. (Closed)

Created:
5 years, 3 months ago by sra1
Modified:
5 years, 3 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M pkg/compiler/lib/src/ssa/builder.dart View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sra1
5 years, 3 months ago (2015-09-19 00:42:01 UTC) #4
Siggi Cherem (dart-lang)
lgtm
5 years, 3 months ago (2015-09-19 01:46:55 UTC) #5
sra1
5 years, 3 months ago (2015-09-19 01:51:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:40001) manually as
19f2296576fa9c325e42b071edfbe1a3755661a6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698