Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1353203002: Delete the typefaces. (Closed)

Created:
5 years, 3 months ago by herb_g
Modified:
5 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M bench/SkGlyphCacheBench.cpp View 2 chunks +3 lines, -0 lines 1 comment Download

Messages

Total messages: 12 (5 generated)
herb_g
Be sure to delete the typefaces.
5 years, 3 months ago (2015-09-18 20:02:45 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1353203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1353203002/1
5 years, 3 months ago (2015-09-18 20:03:33 UTC) #4
tomhudson
lgtm
5 years, 3 months ago (2015-09-18 20:06:24 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-18 20:11:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1353203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1353203002/1
5 years, 3 months ago (2015-09-18 20:51:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/0d39d37ddcfb3847795639eaef513f1112eba627
5 years, 3 months ago (2015-09-18 20:52:21 UTC) #10
bungeman-skia
5 years, 3 months ago (2015-09-18 22:30:31 UTC) #12
Message was sent while issue was closed.
https://codereview.chromium.org/1353203002/diff/1/bench/SkGlyphCacheBench.cpp
File bench/SkGlyphCacheBench.cpp (right):

https://codereview.chromium.org/1353203002/diff/1/bench/SkGlyphCacheBench.cpp...
bench/SkGlyphCacheBench.cpp:61: paint.setTypeface(typeface);
As a note, this is usually written

SkSafeUnref(paint.setTypeface(typeface));

to avoid having to remember to do it separately.

Powered by Google App Engine
This is Rietveld 408576698