Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 135313003: [Telemetry] Disable forecast.io?tap as it is failing on reference builds. (Closed)

Created:
6 years, 11 months ago by tonyg
Modified:
6 years, 11 months ago
CC:
chromium-reviews, chrome-speed-team+watch_google.com
Visibility:
Public.

Description

[Telemetry] Disable forecast.io?tap as it is failing on reference builds. PageActionNotSupported: Synthetic swipe not supported for this browser TBR=rtenneti@chromium.org,dominikg@chromium.org NOTRY=True BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245224

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
tools/perf/page_sets/key_silk_cases.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tonyg
Committed patchset #1 manually as r245224 (presubmit successful).
6 years, 11 months ago (2014-01-16 17:22:03 UTC) #1
Dominik Grewe
On 2014/01/16 17:22:03, tonyg wrote: > Committed patchset #1 manually as r245224 (presubmit successful). I ...
6 years, 11 months ago (2014-01-16 17:43:56 UTC) #2
tonyg
On 2014/01/16 17:43:56, Dominik Grewe wrote: > On 2014/01/16 17:22:03, tonyg wrote: > > Committed ...
6 years, 11 months ago (2014-01-16 17:54:17 UTC) #3
Dominik Grewe
6 years, 11 months ago (2014-01-16 18:32:00 UTC) #4
Message was sent while issue was closed.
On 2014/01/16 17:54:17, tonyg wrote:
> On 2014/01/16 17:43:56, Dominik Grewe wrote:
> > On 2014/01/16 17:22:03, tonyg wrote:
> > > Committed patchset #1 manually as r245224 (presubmit successful).
> > 
> > I think even after the roll this won't work. We're trying to swipe and on
> > desktop systems this shouldn't do anything (at least that's what happening
on
> my
> > Linux machine). And because we don't swipe, the wait_after condition will
> never
> > be true and the test times out.
> > So I'm wondering if we should run this test on desktop bots in the first
> place.
> > If we start running smoothness on this page set, many more pages will fail
> > because they use gestures that are meaningless on desktops without touch.
> 
> I think there's a lot of value in running silk cases on desktop.
> 
> Perhaps we should have a key_silk_cases which runs everywhere and a
> key_mobile_silk_cases which runs only on android.

Yeah, maybe splitting it up would be more sensible if we care about desktop
performance of silk pages. Some pages, forecast.io or mobile-news, are clearly
mobile focused and make heavy use of touch-gestures that just don't work on
desktop.

Powered by Google App Engine
This is Rietveld 408576698