fpdfsdk/src/fpdf_dataavail.cpp - Issue 1353093003: Support linearized loading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/fpdf_dataavail.cpp

Issue 1353093003: Support linearized loading (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Change pdfium_test and add the third return value to indicate an error Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp ('K') | « core/src/fpdfapi/fpdf_parser/parser_int.h ('k') | fpdfsdk/src/fpdf_dataavail_embeddertest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: fpdfsdk/src/fpdf_dataavail.cpp

diff --git a/fpdfsdk/src/fpdf_dataavail.cpp b/fpdfsdk/src/fpdf_dataavail.cpp

index b7b42ab32a6fcfe2bff7686e33e26bde0477db70..cc7b5646c8257ee507a298212216b20b4ae7d93e 100644

--- a/fpdfsdk/src/fpdf_dataavail.cpp

+++ b/fpdfsdk/src/fpdf_dataavail.cpp

@@ -87,10 +87,10 @@ DLLEXPORT void STDCALL FPDFAvail_Destroy(FPDF_AVAIL avail) {

delete (CFPDF_DataAvail*)avail;

}

-DLLEXPORT int STDCALL FPDFAvail_IsDocAvail(FPDF_AVAIL avail,

- FX_DOWNLOADHINTS* hints) {

- if (avail == NULL || hints == NULL)

- return 0;

+DLLEXPORT int STDCALL

+FPDFAvail_IsDocAvail(FPDF_AVAIL avail, FX_DOWNLOADHINTS* hints) {

+ if (!avail || !hints)

+ return PDF_DATA_ERROR;

CFPDF_DownloadHintsWrap hints_wrap(hints);

return ((CFPDF_DataAvail*)avail)->m_pDataAvail->IsDocAvail(&hints_wrap);

}

@@ -124,8 +124,8 @@ DLLEXPORT int STDCALL FPDFAvail_GetFirstPageNum(FPDF_DOCUMENT doc) {

DLLEXPORT int STDCALL FPDFAvail_IsPageAvail(FPDF_AVAIL avail,

int page_index,

FX_DOWNLOADHINTS* hints) {

- if (avail == NULL || hints == NULL)

- return 0;

+ if (!avail || !hints)

+ return PDF_DATA_ERROR;

CFPDF_DownloadHintsWrap hints_wrap(hints);

return ((CFPDF_DataAvail*)avail)

->m_pDataAvail->IsPageAvail(page_index, &hints_wrap);

@@ -133,14 +133,14 @@ DLLEXPORT int STDCALL FPDFAvail_IsPageAvail(FPDF_AVAIL avail,

DLLEXPORT int STDCALL FPDFAvail_IsFormAvail(FPDF_AVAIL avail,

FX_DOWNLOADHINTS* hints) {

- if (avail == NULL || hints == NULL)

- return -1;

+ if (!avail || !hints)

+ return PDF_FORM_AVAIL;

CFPDF_DownloadHintsWrap hints_wrap(hints);

return ((CFPDF_DataAvail*)avail)->m_pDataAvail->IsFormAvail(&hints_wrap);

}

-DLLEXPORT FPDF_BOOL STDCALL FPDFAvail_IsLinearized(FPDF_AVAIL avail) {

- if (avail == NULL)

- return -1;

+DLLEXPORT int STDCALL FPDFAvail_IsLinearized(FPDF_AVAIL avail) {

+ if (!avail)

+ return PDF_LINEARIZATION_UNKNOWN;

return ((CFPDF_DataAvail*)avail)->m_pDataAvail->IsLinearizedPDF();

}