Support linearized loading

testing/embedder_test.cpp

 // Copyright (c) 2015 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "embedder_test.h"
 
 #include <limits.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 
 #include <list>
 #include <string>
 #include <utility>
 #include <vector>
 
 #include "../public/fpdf_text.h"
-#include "../public/fpdfview.h"
+#include "../public/fpdf_dataavail.h"

[Tom Sepez, 2015/09/22 19:17:59]

nit: alphabetize.

[jun_fang, 2015/09/23 12:26:59]

Acknowledged.

 #include "testing/gmock/include/gmock/gmock.h"
 #include "v8/include/libplatform/libplatform.h"
 #include "v8/include/v8.h"
 
 #ifdef _WIN32
 #define snprintf _snprintf
 #define PATH_SEPARATOR '\\'
 #else
 #define PATH_SEPARATOR '/'
 #endif
@@ skipping 164 matching lines @@
   file_access_.m_GetBlock = Get_Block;
   file_access_.m_Param = loader_;
 
   file_avail_.version = 1;
   file_avail_.IsDataAvail = Is_Data_Avail;
 
   hints_.version = 1;
   hints_.AddSegment = Add_Segment;
 
   avail_ = FPDFAvail_Create(&file_avail_, &file_access_);
-  (void)FPDFAvail_IsDocAvail(avail_, &hints_);
-
-  if (!FPDFAvail_IsLinearized(avail_)) {
+  if (FPDFAvail_IsLinearized(avail_) != FSDK_IS_LINEARIZED) {
     document_ = FPDF_LoadCustomDocument(&file_access_, nullptr);
   } else {
     document_ = FPDFAvail_GetDocument(avail_, nullptr);
+    while (true) {

[Tom Sepez, 2015/09/22 19:17:59]

strange spinnng here. do you have to yield or check something else? Are we sure
that it will eventually return true?
associated nit: I'd write
  while (!FPDFAvail_IsDocAvail(avail_, &hints_))
    continue;

[jun_fang, 2015/09/23 12:26:59]

If the return value is false, that means we need to wait for data to be
downloaded.

[Tom Sepez, 2015/09/24 18:24:40]

So...do we need an IFX_Pause or some such to check here?

+      if (FPDFAvail_IsDocAvail(avail_, &hints_))
+        break;
+    }
+    if (FPDFAvail_IsFormAvail(avail_, &hints_) == PDFFORM_NOTAVAIL) {
+      return false;
+    }
+    int page_count = FPDF_GetPageCount(document_);
+    for (int i = 0; i < page_count; ++i) {
+      while (true) {

[Tom Sepez, 2015/09/22 19:17:59]

nit: same here.

[jun_fang, 2015/09/23 12:26:59]

Acknowledged.

+        if (FPDFAvail_IsPageAvail(avail_, i, &hints_))
+          break;
+      }
+    }
   }
-
+  if (!document_)
+    return false;
   (void)FPDF_GetDocPermissions(document_);
-  (void)FPDFAvail_IsFormAvail(avail_, &hints_);
 
   IPDF_JSPLATFORM* platform = static_cast<IPDF_JSPLATFORM*>(this);
   memset(platform, 0, sizeof(IPDF_JSPLATFORM));
   platform->version = 2;
   platform->app_alert = AlertTrampoline;
 
   FPDF_FORMFILLINFO* formfillinfo = static_cast<FPDF_FORMFILLINFO*>(this);
   memset(formfillinfo, 0, sizeof(FPDF_FORMFILLINFO));
   formfillinfo->version = 1;
   formfillinfo->FFI_SetTimer = SetTimerTrampoline;
@@ skipping 118 matching lines @@
 }
 
 // Can't use gtest-provided main since we need to stash the path to the
 // executable in order to find the external V8 binary data files.
 int main(int argc, char** argv) {
   g_exe_path_ = argv[0];
   testing::InitGoogleTest(&argc, argv);
   testing::InitGoogleMock(&argc, argv);
   return RUN_ALL_TESTS();
 }