Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1622)

Unified Diff: Tools/GardeningServer/scripts/ui/notifications.js

Issue 135303006: Garden-o-matic: Stop the tab explosion! (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/scripts/ui/notifications.js
diff --git a/Tools/GardeningServer/scripts/ui/notifications.js b/Tools/GardeningServer/scripts/ui/notifications.js
index 40d2539c8bcbe25012b6f7ef6c225b09a74e39f5..b83ad2314bce1f763d2f7a85b6e1ed6321786532 100644
--- a/Tools/GardeningServer/scripts/ui/notifications.js
+++ b/Tools/GardeningServer/scripts/ui/notifications.js
@@ -96,7 +96,7 @@ ui.notifications.Info = base.extends(ui.notifications.Notification, {
ui.notifications.FailingTestGroup = base.extends('li', {
init: function(groupName, testNameList)
{
- this.appendChild(base.createLinkNode(ui.urlForFlakinessDashboard(testNameList), groupName, '_blank'));
+ this.appendChild(base.createLinkNode(ui.urlForFlakinessDashboard(testNameList), groupName));
}
});
@@ -112,7 +112,7 @@ ui.notifications.SuspiciousCommit = base.extends(Cause, {
init: function(commitData)
{
this._revision = commitData.revision;
- this._description.appendChild(base.createLinkNode(trac.changesetURL(commitData.revision), commitData.revision, '_blank'));
+ this._description.appendChild(base.createLinkNode(trac.changesetURL(commitData.revision), commitData.revision));
this._details = this._description.appendChild(document.createElement('span'));
this._addDetail('summary', commitData);
this._addDetail('author', commitData);
@@ -134,7 +134,7 @@ ui.notifications.SuspiciousCommit = base.extends(Cause, {
span.className = part;
if (linkFunction) {
- var link = base.createLinkNode(linkFunction(content), content, '_blank');
+ var link = base.createLinkNode(linkFunction(content), content);
span.appendChild(link);
} else
span.textContent = content;
« no previous file with comments | « Tools/GardeningServer/scripts/ui/failures_unittests.js ('k') | Tools/GardeningServer/scripts/ui/notifications_unittests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698