Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 135303006: Garden-o-matic: Stop the tab explosion! (Closed)

Created:
6 years, 11 months ago by pdr.
Modified:
6 years, 11 months ago
Reviewers:
cmp, ojan, dglazkov, dglazkov1
CC:
blink-reviews
Visibility:
Public.

Description

Garden-o-matic: Stop the tab explosion! This patch stops garden-o-matic from opening links in new tabs. Users that like this feature are free to use the middle-click or ctrl+click to open links in a new tab. This will increase gardener happiness by 34% (sample size of 1, measured today). R=ojan, dglazkov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165341

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -35 lines) Patch
M Tools/GardeningServer/scripts/controllers_unittests.js View 1 chunk +1 line, -1 line 0 comments Download
M Tools/GardeningServer/scripts/ui/failures.js View 1 chunk +0 lines, -1 line 0 comments Download
M Tools/GardeningServer/scripts/ui/failures_unittests.js View 5 chunks +9 lines, -9 lines 0 comments Download
M Tools/GardeningServer/scripts/ui/notifications.js View 3 chunks +3 lines, -3 lines 0 comments Download
M Tools/GardeningServer/scripts/ui/notifications_unittests.js View 14 chunks +19 lines, -19 lines 0 comments Download
M Tools/GardeningServer/scripts/ui/results.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
pdr.
6 years, 11 months ago (2014-01-16 23:30:18 UTC) #1
dglazkov
lgtm. Sample size is a bit small, but the gains are substantial.
6 years, 11 months ago (2014-01-16 23:41:32 UTC) #2
pdr.
On 2014/01/16 23:41:32, Dimitri Glazkov wrote: > lgtm. Sample size is a bit small, but ...
6 years, 11 months ago (2014-01-16 23:43:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/135303006/1
6 years, 11 months ago (2014-01-16 23:43:23 UTC) #4
dglazkov
On 2014/01/16 23:43:05, pdr wrote: > Thank you Dimitri! If future gardeners complain I'm happy ...
6 years, 11 months ago (2014-01-16 23:47:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/135303006/1
6 years, 11 months ago (2014-01-17 19:16:28 UTC) #6
cmp
On 2014/01/17 19:16:28, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 11 months ago (2014-01-17 19:17:40 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 21:23:34 UTC) #8
Message was sent while issue was closed.
Change committed as 165341

Powered by Google App Engine
This is Rietveld 408576698