google_apis/gcm/gcm.gyp - Issue 135303002: Adding a user list (to be consumed by GCM Client Implementation)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/gcm.gyp

Issue 135303002: Adding a user list (to be consumed by GCM Client Implementation) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated the code with CR feedback, applied more asynch model. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: google_apis/gcm/gcm.gyp

diff --git a/google_apis/gcm/gcm.gyp b/google_apis/gcm/gcm.gyp

index ad4989ab1c8eb4bced059ee9d47745f347b8d433..f1727e00c9a2e07ca5a3f2d3c4234a86714cb350 100644

--- a/google_apis/gcm/gcm.gyp

+++ b/google_apis/gcm/gcm.gyp

@@ -64,6 +64,8 @@

'engine/mcs_client.h',

'engine/registration_request.cc',

'engine/registration_request.h',

+ 'engine/user_list.cc',

+ 'engine/user_list.h',

'gcm_client.cc',

'gcm_client.h',

'gcm_client_impl.cc',

@@ -133,6 +135,7 @@

'engine/heartbeat_manager_unittest.cc',

'engine/mcs_client_unittest.cc',

'engine/registration_request_unittest.cc',

+ 'engine/user_list_unittest.cc',

]

« google_apis/gcm/engine/user_list_unittest.cc ('K') | « google_apis/gcm/engine/user_list_unittest.cc ('k') | google_apis/gcm/gcm_client_impl.h » ('j') | no next file with comments »