Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1353023003: [turbofan] Merge group spill ranges. (Closed)

Created:
5 years, 3 months ago by Mircea Trofin
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer, *Jarin
CC:
v8-reviews_googlegroups.com, Jim Stichnoth, jvoung (off chromium)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Merge group spill ranges. Akin to linear scan's TryReuseSpillForPhi, we attempt to merge the spill ranges of grouped live ranges (which are phi inputs and output), to avoid inefficient slot-to-slot moves. BUG= Committed: https://crrev.com/7864c35a76ee490d1676168d51ef6c8ca3ece14b Cr-Commit-Position: refs/heads/master@{#30833}

Patch Set 1 : #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
M src/compiler/greedy-allocator.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/greedy-allocator.cc View 1 2 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Mircea Trofin
5 years, 3 months ago (2015-09-18 05:05:59 UTC) #3
Benedikt Meurer
LGTM from my side. https://codereview.chromium.org/1353023003/diff/40001/src/compiler/greedy-allocator.cc File src/compiler/greedy-allocator.cc (right): https://codereview.chromium.org/1353023003/diff/40001/src/compiler/greedy-allocator.cc#newcode491 src/compiler/greedy-allocator.cc:491: if (!CanProcessRange(top) || !top->is_phi() || ...
5 years, 3 months ago (2015-09-18 06:08:36 UTC) #5
Jarin
lgtm
5 years, 3 months ago (2015-09-18 07:14:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1353023003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1353023003/60001
5 years, 3 months ago (2015-09-18 15:35:08 UTC) #9
Mircea Trofin
https://codereview.chromium.org/1353023003/diff/40001/src/compiler/greedy-allocator.cc File src/compiler/greedy-allocator.cc (right): https://codereview.chromium.org/1353023003/diff/40001/src/compiler/greedy-allocator.cc#newcode491 src/compiler/greedy-allocator.cc:491: if (!CanProcessRange(top) || !top->is_phi() || top->group() == nullptr) On ...
5 years, 3 months ago (2015-09-18 15:35:35 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 3 months ago (2015-09-18 16:01:57 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 16:02:11 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7864c35a76ee490d1676168d51ef6c8ca3ece14b
Cr-Commit-Position: refs/heads/master@{#30833}

Powered by Google App Engine
This is Rietveld 408576698