Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 135293002: Remove a bunch of stale entries from our BUILD.gn files. (Closed)

Created:
6 years, 11 months ago by tfarina
Modified:
6 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Remove a bunch of stale entries from our BUILD.gn files. BUG=None TEST=gn, ninja -C out/Default goes until it needs grit/net_resources.h R=brettw@chromium.org TBR=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244362

Patch Set 1 #

Patch Set 2 : fix for win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -33 lines) Patch
M tools/gn/secondary/skia/BUILD.gn View 1 18 chunks +0 lines, -32 lines 0 comments Download
M tools/gn/secondary/third_party/WebKit/Source/wtf/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
tfarina
TBRing...
6 years, 11 months ago (2014-01-11 01:26:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/135293002/1
6 years, 11 months ago (2014-01-11 02:03:02 UTC) #2
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=245188
6 years, 11 months ago (2014-01-11 02:39:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/135293002/1
6 years, 11 months ago (2014-01-11 03:14:04 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=66841
6 years, 11 months ago (2014-01-11 04:11:29 UTC) #5
brettw
lgtm
6 years, 11 months ago (2014-01-11 06:43:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/135293002/1
6 years, 11 months ago (2014-01-11 06:44:14 UTC) #7
commit-bot: I haz the power
Retried try job too often on win for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=139749
6 years, 11 months ago (2014-01-11 07:33:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/135293002/1
6 years, 11 months ago (2014-01-11 14:05:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/135293002/520001
6 years, 11 months ago (2014-01-11 14:31:01 UTC) #10
tfarina
6 years, 11 months ago (2014-01-11 22:25:28 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 manually as r244362 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698