Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 1352923003: Fix webkit_unit_tests.isolate to use ' instead of ". (Closed)

Created:
5 years, 3 months ago by joelo
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke, M-A Ruel
CC:
blink-reviews, estaab
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix webkit_unit_tests.isolate to use ' instead of ". Double quotes cause isolate.go to choke with the following error: webkit_unit_tests failed to process isolate (isolateDir: /usr/local/google/home/joelo/src/chromium/src/third_party/WebKit/Source/web): invalid character '\\' looking for beginning of value BUG=524758, 531819 TBR=dpranke@chromium.org,maruel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202495

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/web/webkit_unit_tests.isolate View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1352923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1352923003/1
5 years, 3 months ago (2015-09-17 22:04:43 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/70574)
5 years, 3 months ago (2015-09-17 23:45:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1352923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1352923003/1
5 years, 3 months ago (2015-09-18 01:37:51 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 03:02:52 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202495

Powered by Google App Engine
This is Rietveld 408576698