Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1352913002: Remove Windows support from the EDK. (Closed)

Created:
5 years, 3 months ago by viettrungluu
Modified:
5 years, 3 months ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove Windows support from the EDK. We already can't build it from our repo and, with it no longer being rolled into Chromium, Windows support is totally unused and unmaintable. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/7e4b251a5f22ba1bfdb602868259973cf29091e4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1126 lines) Patch
M mojo/edk/embedder/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M mojo/edk/embedder/embedder.h View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/edk/embedder/platform_channel_pair.h View 3 chunks +6 lines, -15 lines 0 comments Download
D mojo/edk/embedder/platform_channel_pair_win.cc View 1 chunk +0 lines, -111 lines 0 comments Download
M mojo/edk/embedder/platform_handle.h View 2 chunks +1 line, -21 lines 0 comments Download
M mojo/edk/embedder/platform_handle.cc View 2 chunks +0 lines, -15 lines 0 comments Download
D mojo/edk/embedder/platform_handle_utils_win.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M mojo/edk/embedder/scoped_platform_handle.h View 1 chunk +1 line, -2 lines 0 comments Download
D mojo/edk/embedder/simple_platform_shared_buffer_win.cc View 1 chunk +0 lines, -88 lines 0 comments Download
M mojo/edk/system/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/edk/system/message_pipe_dispatcher_unittest.cc View 1 chunk +1 line, -7 lines 0 comments Download
M mojo/edk/system/multiprocess_message_pipe_unittest.cc View 4 chunks +9 lines, -11 lines 0 comments Download
M mojo/edk/system/raw_channel_unittest.cc View 2 chunks +1 line, -8 lines 0 comments Download
D mojo/edk/system/raw_channel_win.cc View 1 chunk +0 lines, -632 lines 0 comments Download
M mojo/edk/system/remote_message_pipe_unittest.cc View 3 chunks +2 lines, -15 lines 0 comments Download
M mojo/edk/system/simple_dispatcher_unittest.cc View 3 chunks +3 lines, -21 lines 0 comments Download
M mojo/edk/system/test_utils.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M mojo/edk/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/edk/test/multiprocess_test_helper.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M mojo/edk/test/multiprocess_test_helper_unittest.cc View 1 chunk +2 lines, -10 lines 0 comments Download
M mojo/edk/test/test_support_impl.cc View 2 chunks +1 line, -7 lines 0 comments Download
D mojo/edk/test/test_utils_win.cc View 1 chunk +0 lines, -112 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
5 years, 3 months ago (2015-09-17 17:16:58 UTC) #1
jamesr
lgtm
5 years, 3 months ago (2015-09-17 17:29:29 UTC) #2
viettrungluu
5 years, 3 months ago (2015-09-17 17:39:30 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
7e4b251a5f22ba1bfdb602868259973cf29091e4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698