Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: webkit/fileapi/media/picasa/pmp_table_reader_unittest.cc

Issue 13529028: PicasaAlbumTableReader for Media Galleries API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0005-picasa-import-pmp-reader
Patch Set: Remove PmpTableReader::Init, fix up some tests Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/fileapi/media/picasa/pmp_table_reader_unittest.cc
diff --git a/webkit/fileapi/media/picasa/pmp_table_reader_unittest.cc b/webkit/fileapi/media/picasa/pmp_table_reader_unittest.cc
index 66d3fa13602cba968d02164356c6deb351c223c0..a47ea500bb7e91376bc1b6c92c64059ca7344633 100644
--- a/webkit/fileapi/media/picasa/pmp_table_reader_unittest.cc
+++ b/webkit/fileapi/media/picasa/pmp_table_reader_unittest.cc
@@ -55,18 +55,15 @@ TEST(PmpTableReaderTest, RowCountAndFieldType) {
ASSERT_TRUE(test_helper.WriteColumnFileFromVector(
table_name, column_names[2], column_field_types[2], doubles_vector));
- picasaimport::PmpTableReader table_reader;
- ASSERT_TRUE(table_reader.Init(
- table_name, test_helper.GetTempDirPath(), column_names));
+ picasaimport::PmpTableReader table_reader(table_name,
+ test_helper.GetTempDirPath());
- EXPECT_EQ(max_rows, table_reader.RowCount());
-
- const std::vector<const picasaimport::PmpColumnReader*> column_readers =
- table_reader.GetColumns();
-
- for (int i = 0; i < 3; i++) {
- EXPECT_EQ(column_field_types[i], column_readers[i]->field_type());
+ for (unsigned int i = 0; i < column_names.size(); i++) {
+ ASSERT_TRUE(
+ table_reader.AddColumn(column_names[i], column_field_types[i]) != NULL);
}
+
+ EXPECT_EQ(max_rows, table_reader.RowCount());
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698