PicasaAlbumTableReader for Media Galleries API

webkit/fileapi/media/picasa/pmp_column_reader.cc

Index: webkit/fileapi/media/picasa/pmp_column_reader.cc
diff --git a/webkit/fileapi/media/picasa/pmp_column_reader.cc b/webkit/fileapi/media/picasa/pmp_column_reader.cc
index 2e6777ae0a0ecb0f04d32af14805d972bf5ded54..9c85f543a366ec63f4b44423221fb225f1507dcb 100644
--- a/webkit/fileapi/media/picasa/pmp_column_reader.cc
+++ b/webkit/fileapi/media/picasa/pmp_column_reader.cc
@@ -19,14 +19,17 @@ const size_t kPmpMaxFilesize = 50*1024*1024; // Maximum of 50 MB.
 
 }  // namespace
 
-PmpColumnReader::PmpColumnReader()
-    : length_(0),
+PmpColumnReader::PmpColumnReader(const std::string& column_name)
+    : column_name_(column_name),
+      length_(0),
       field_type_(PMP_INVALID_TYPE),
-      rows_(0) { }
+      rows_(0) {}
 
-PmpColumnReader::~PmpColumnReader() { }
+PmpColumnReader::~PmpColumnReader() {}
 
-bool PmpColumnReader::Init(const base::FilePath& filepath, uint32* rows_read) {
+bool PmpColumnReader::Init(const base::FilePath& filepath,
+                           const PmpFieldType expected_type,
+                           uint32* rows_read) {
   DCHECK(!data_.get());
   base::ThreadRestrictions::AssertIOAllowed();
 
@@ -44,7 +47,7 @@ bool PmpColumnReader::Init(const base::FilePath& filepath, uint32* rows_read) {
   char* data_begin = reinterpret_cast<char*>(data_.get());
 
   return file_util::ReadFile(filepath, data_begin, length_) &&
-         ParseData(rows_read);
+         ParseData(expected_type, rows_read);

[vandebo (ex-Chrome), 2013/04/09 19:16:56]

nit: indent is wrong

[tommycli, 2013/04/11 18:24:05]

Left as is.

 }
 
 bool PmpColumnReader::ReadString(const uint32 row, std::string* result) const {
@@ -102,7 +105,8 @@ bool PmpColumnReader::ReadUInt64(const uint32 row, uint64* result) const {
   return true;
 }
 
-bool PmpColumnReader::ParseData(uint32* rows_read) {
+bool PmpColumnReader::ParseData(const PmpFieldType expected_type,
+                                uint32* rows_read) {
   DCHECK(data_.get() != NULL);
   DCHECK_GE(length_, kPmpHeaderSize);
 
@@ -125,6 +129,9 @@ bool PmpColumnReader::ParseData(uint32* rows_read) {
 
   field_type_ = static_cast<PmpFieldType>(field_type_data);
 
+  if (field_type_ != expected_type)
+    return false;
+
   rows_ = *(reinterpret_cast<uint32*>(&data_[kPmpRowCountOffset]));
 
   size_t body_length = length_ - kPmpHeaderSize;