PicasaAlbumTableReader for Media Galleries API

webkit/fileapi/media/picasa/pmp_table_reader.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_FILEAPI_MEDIA_PICASA_PMP_TABLE_READER_H_
 #define WEBKIT_FILEAPI_MEDIA_PICASA_PMP_TABLE_READER_H_
 
 #include <string>
 
 #include "base/basictypes.h"
+#include "base/files/file_path.h"
 #include "base/memory/scoped_vector.h"
+#include "webkit/fileapi/media/picasa/pmp_constants.h"
 #include "webkit/storage/webkit_storage_export.h"
 
 namespace base {
 class FilePath;
 }
 
 namespace picasaimport {
 
 class PmpColumnReader;
 
 class WEBKIT_STORAGE_EXPORT_PRIVATE PmpTableReader {
  public:
-  PmpTableReader();
+  PmpTableReader(const std::string& table_name,
+                 const base::FilePath& directory_path);
 
   virtual ~PmpTableReader();
 
   // |columns| parameter will define, in-order, the columns returned by

[vandebo (ex-Chrome), 2013/04/08 23:57:24]

Comment is out of date.

[tommycli, 2013/04/09 00:45:34]

I see what you mean about comments being a burden sometimes.

   // subsequent columns to GetColumns() if Init() succeeds.
-  bool Init(const std::string& table_name,
-            const base::FilePath& directory_path,
-            const std::vector<std::string>& columns);
+  bool Init();
+
+  // Returns NULL on failure.
+  const PmpColumnReader* AddColumn(const std::string& column_name,
+                                   const PmpFieldType expected_type);
 
   // Returns a const "view" of the current contents of |column_readers_|.
   std::vector<const PmpColumnReader*> GetColumns() const;

[vandebo (ex-Chrome), 2013/04/08 23:57:24]

std:map

[tommycli, 2013/04/09 00:45:34]

Done.

 
+  // This value may change after calls to AddColumn().
   uint32 RowCount() const;
 
  private:
+  std::string table_name_;
+  base::FilePath directory_path_;
+
   ScopedVector<PmpColumnReader> column_readers_;
   uint32 max_row_count_;
 
   DISALLOW_COPY_AND_ASSIGN(PmpTableReader);
 };
 
 }  // namespace picasaimport
 
 #endif  // WEBKIT_FILEAPI_MEDIA_PICASA_PMP_TABLE_READER_H_