Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 13529020: MacTerminateOnHeapCorruption shouldn't leak the OOM killer into the shared test context. (Closed)

Created:
7 years, 8 months ago by Avi (use Gerrit)
Modified:
7 years, 8 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, jln (very slow on Chromium)
Visibility:
Public.

Description

MacTerminateOnHeapCorruption shouldn't leak the OOM killer into the shared test context. BUG=196349 TEST=SecurityTest.NewOverflow and CallocOverflow should not fail as part of a long test run Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192660

Patch Set 1 #

Total comments: 1

Patch Set 2 : formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M base/process_util_unittest.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Avi (use Gerrit)
7 years, 8 months ago (2013-04-05 18:12:00 UTC) #1
Robert Sesek
lgtm https://codereview.chromium.org/13529020/diff/1/base/process_util_unittest.cc File base/process_util_unittest.cc (right): https://codereview.chromium.org/13529020/diff/1/base/process_util_unittest.cc#newcode556 base/process_util_unittest.cc:556: buf = malloc(std::numeric_limits<size_t>::max() - (2 * PAGE_SIZE) - ...
7 years, 8 months ago (2013-04-05 18:13:22 UTC) #2
Avi (use Gerrit)
nicer?
7 years, 8 months ago (2013-04-05 18:23:59 UTC) #3
Robert Sesek
Yes. LGTM++
7 years, 8 months ago (2013-04-05 18:24:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/13529020/4001
7 years, 8 months ago (2013-04-05 18:25:32 UTC) #5
commit-bot: I haz the power
Presubmit check for 13529020-4001 failed and returned exit status 1. INFO:root:Found 1 file(s). Running presubmit ...
7 years, 8 months ago (2013-04-05 18:25:34 UTC) #6
Avi (use Gerrit)
Mark, you're an owner here.
7 years, 8 months ago (2013-04-05 18:26:24 UTC) #7
Mark Mentovai
Definitely LGTM
7 years, 8 months ago (2013-04-05 18:47:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/13529020/4001
7 years, 8 months ago (2013-04-05 18:56:35 UTC) #9
commit-bot: I haz the power
7 years, 8 months ago (2013-04-06 00:11:15 UTC) #10
Message was sent while issue was closed.
Change committed as 192660

Powered by Google App Engine
This is Rietveld 408576698