Use locale insensitive method to parse double literals.

runtime/lib/double.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <math.h>
 
 #include "vm/bootstrap_natives.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/code_generator.h"  // DartModulo.
@@ skipping 203 matching lines @@
         const char* tmp = cstr;
         while (*tmp != '\0') {
           const char ch = *tmp++;
           if (ch == '.') {
             const char nextCh = *tmp;
             dot_ok = ('0' <= nextCh) && (nextCh <= '9');
             break;
           }
         }
         if (dot_ok) {
-          char* p_end = NULL;
-          const double double_value = strtod(cstr, &p_end);
-          if (p_end == (cstr + len)) {
+          double double_value;
+          if (CStringToDouble(cstr, len, &double_value)) {
             return Double::New(double_value);
           }
         }
       }
     }
   }
   Scanner scanner(value, Symbols::Empty());
   const Scanner::GrowableTokenStream& tokens = scanner.GetStream();
   String* number_string;
   bool is_positive;
   if (Scanner::IsValidLiteral(tokens,
                               Token::kDOUBLE,
                               &is_positive,
                               &number_string)) {
+    ASSERT(number_string->IsOneByteString());

[Ivan Posva, 2013/04/05 21:56:42]

Please explain here why you are allowed to make this assertion. It is rather
confusing as above we short-circuit for OneByteString.

[Vyacheslav Egorov (Google), 2013/04/08 14:25:04]

Done.

     const char* cstr = number_string->ToCString();
-    char* p_end = NULL;
-    double double_value = strtod(cstr, &p_end);
-    ASSERT(p_end != cstr);
+
+    double double_value;
+    bool ok = CStringToDouble(cstr, number_string->Length(), &double_value);
+    USE(ok);

[Ivan Posva, 2013/04/05 21:56:42]

I would have thought USE is not necessary here.

[Vyacheslav Egorov (Google), 2013/04/08 14:25:04]

Done.

+    ASSERT(ok);
+
     if (!is_positive) {
       double_value = -double_value;
     }
     return Double::New(double_value);
   }
 
   if (Scanner::IsValidLiteral(tokens,
                               Token::kINTEGER,
                               &is_positive,
                               &number_string)) {
@@ skipping 98 matching lines @@
 
 DEFINE_NATIVE_ENTRY(Double_getIsNegative, 1) {
   const Double& arg = Double::CheckedHandle(arguments->NativeArgAt(0));
   // Include negative zero, infinity.
   return Bool::Get(signbit(arg.value()) && !isnan(arg.value()));
 }
 
 // Add here only functions using/referring to old-style casts.
 
 }  // namespace dart